Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds basic blog functionality #339

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

jorydotcom
Copy link

Closes #309

Adds:

  • _posts directory + collection
  • 'Blog' to main nav
  • Layouts for post pages, post-list

Note:
I am not a designer 😂 but see attached screenshots; need to nuke _posts before merging (unless someone wants to merge with an inaugural blog post!)

Screen Shot 2022-03-29 at 1 28 59 PM

Screen Shot 2022-03-29 at 1 28 40 PM

Signed-off-by: Jory Burson jburson@linuxfoundation.org

@netlify
Copy link

netlify bot commented Mar 29, 2022

Deploy Preview for slsa ready!

Name Link
🔨 Latest commit 3ad8d8a
🔍 Latest deploy log https://app.netlify.com/sites/slsa/deploys/62506e399f62250009f2e56c
😎 Deploy Preview https://deploy-preview-339--slsa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@TomHennen
Copy link
Contributor

Thanks so much! @MarkLodato did you want to review this or are you happy for someone else to do so?

@inferno-chromium inferno-chromium requested a review from a team March 30, 2022 16:54
@inferno-chromium
Copy link
Contributor

Thanks so much! @MarkLodato did you want to review this or are you happy for someone else to do so?

@TomHennen feel free to review as well. Also, i think some minor layout things can be improved (e.g. spacing before each blog title, split row colors e.g. on overview page, etc), this can be come in next CL.

Copy link
Member

@MarkLodato MarkLodato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Jory! I think this is great.

Note that the spacing between paragraph is bad due to #335, if anyone is willing to fix that in a separate PR.

docs/_data/nav.yml Outdated Show resolved Hide resolved
docs/blog.html Outdated Show resolved Hide resolved
docs/_posts/2022-03-29-test.md Outdated Show resolved Hide resolved
docs/_config.yml Outdated Show resolved Hide resolved
@inferno-chromium inferno-chromium merged commit 5692cad into slsa-framework:main Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SLSA Blog
5 participants