Add fixed stable version of controller #21
Conversation
| with: | ||
| context: . | ||
| push: true | ||
| tags: ${{ env.REGISTRY_PATH }}/ocrd_controller:stable |
There was a problem hiding this comment.
Perhaps we can even add some release tag here:
| tags: ${{ env.REGISTRY_PATH }}/ocrd_controller:stable | |
| tags: ${{ env.REGISTRY_PATH }}/ocrd_controller:stable,${{ env.REGISTRY_PATH }}/ocrd_controller:${{ env.vcs_tag }} |
(Will be just HEAD if there is no tag for it.)
There was a problem hiding this comment.
The question was whether saving the tags will cause problems on GitHub. I assumed that the stable tag simply overrides the stable image version.
There was a problem hiding this comment.
I assumed that the stable tag simply overrides the stable image version.
I'm sure it does. This is just to make sure we also produce some persistent images ourselves from time to time (viz. whenever we decide to make a release).
There was a problem hiding this comment.
Why didn't you commit my suggestions?
There was a problem hiding this comment.
oh I thought I had already done that. Was not intentional. I'll change that directly.
There was a problem hiding this comment.
Added your suggest changes with seperate pr #22
Atm the stable version rebuilds with same behaviour like the latest version but with the different of using the parent version. So when something in Controller repo is changed than the stable version rebuilds too. |
Fixes #11