Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixed stable version of controller #21

Merged
merged 3 commits into from
Feb 15, 2023
Merged

Add fixed stable version of controller #21

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
809d40a
Add fixed stable version of controller
markusweigelt Feb 14, 2023
2e477de
add cache scope
markusweigelt Feb 14, 2023
5719667
remove scope again cause use layer cache
markusweigelt Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ on:

env:
REGISTRY_PATH: ghcr.io/slub
STABLE_VERSION: 2023-02-07 # manually adjusted when tested https://github.com/slub/ocrd_kitodo

jobs:

Expand All @@ -34,7 +35,7 @@ jobs:
date -u +"build_date=%Y-%m-%dT%H:%M:%SZ" >> $GITHUB_ENV
echo "vcs_ref=`git rev-parse --short HEAD`" >> $GITHUB_ENV

- name: Build the OCR-D Controller image and deploy to GitHub Container Repository
- name: Build the latest OCR-D Controller image and deploy to GitHub Container Repository
uses: docker/build-push-action@v3
with:
context: .
Expand All @@ -44,5 +45,17 @@ jobs:
BUILD_DATE=${{ env.build_date }}
VCS_REF=${{ env.vcs_ref }}
cache-from: type=gha
cache-to: type=gha,mode=max

cache-to: type=gha,mode=max

- name: Build the stable OCR-D Controller image and deploy to GitHub Container Repository
uses: docker/build-push-action@v4
with:
context: .
push: true
tags: ${{ env.REGISTRY_PATH }}/ocrd_controller:stable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can even add some release tag here:

Suggested change
tags: ${{ env.REGISTRY_PATH }}/ocrd_controller:stable
tags: ${{ env.REGISTRY_PATH }}/ocrd_controller:stable,${{ env.REGISTRY_PATH }}/ocrd_controller:${{ env.vcs_tag }}

(Will be just HEAD if there is no tag for it.)

Copy link
Collaborator Author

@markusweigelt markusweigelt Feb 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The question was whether saving the tags will cause problems on GitHub. I assumed that the stable tag simply overrides the stable image version.

Copy link
Member

@bertsky bertsky Feb 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assumed that the stable tag simply overrides the stable image version.

I'm sure it does. This is just to make sure we also produce some persistent images ourselves from time to time (viz. whenever we decide to make a release).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn't you commit my suggestions?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I thought I had already done that. Was not intentional. I'll change that directly.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added your suggest changes with seperate pr #22

build-args: |
BUILD_DATE=${{ env.build_date }}
VCS_REF=${{ env.vcs_ref }}
VERSION=${{ env.STABLE_VERSION }}
cache-from: type=gha
cache-to: type=gha,mode=max