Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract TCK tests to a separate Maven module and remove reactive-streams-junit5-tck using a TestNG JUnit5 runner #782

Closed
jponge opened this issue Dec 16, 2021 · 0 comments · Fixed by #793
Closed

Extract TCK tests to a separate Maven module and remove reactive-streams-junit5-tck using a TestNG JUnit5 runner #782

jponge opened this issue Dec 16, 2021 · 0 comments · Fixed by #793
Assignees
@jponge
Labels
ci/cd/build CI/CD pipeline and build good first issue Good for newcomers technical-debt Technical debt reduction
Milestone
1.3.0

Comments

@jponge
Copy link
Member

jponge commented Dec 16, 2021

The RS TCK tests are currently present in the mutiny module test suite. We've had to develop a small shim in reactive-streams-junit5-tck to run the TCK (based on TestNG) in JUnit5.

We should instead:

  1. remove reactive-streams-junit5-tck,
  2. introduce a module for running the RS TCK tests
  3. move our existing tests here, and make them TestNG tests again
  4. use https://github.com/testng-team/testng-junit5 as a runner
@jponge jponge added good first issue Good for newcomers technical-debt Technical debt reduction ci/cd/build CI/CD pipeline and build labels Dec 16, 2021
@jponge jponge added this to the 1.3.0 milestone Jan 3, 2022
@jponge jponge self-assigned this Jan 3, 2022
jponge added a commit that referenced this issue Jan 3, 2022
@jponge
Remove reactive-streams-junit5-tck and switch back to plain RS TestNG…
b96f5a1 
… TCK

This removes the reactive-streams-junit5-tck JUnit5 shim around the RS TCK.

TCK checks have been moved to the reactive-streams-tck-tests module, using plain TestNG, and running using a dedicated JUnit 5 engine.

Closes #782
@jponge jponge mentioned this issue Jan 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jponge jponge

Labels
ci/cd/build CI/CD pipeline and build good first issue Good for newcomers technical-debt Technical debt reduction
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

Remove reactive-streams-junit5-tck and switch back to plain RS TestNG TCK smallrye/smallrye-mutiny
1 participant
@jponge