Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reactive-streams-junit5-tck and switch back to plain RS TestNG TCK #793

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

jponge
Copy link
Member

@jponge jponge commented Jan 3, 2022

This removes the reactive-streams-junit5-tck JUnit5 shim around the RS TCK.

TCK checks have been moved to the reactive-streams-tck-tests module, using plain TestNG, and running using a dedicated JUnit 5 engine.

Closes #782

… TCK

This removes the reactive-streams-junit5-tck JUnit5 shim around the RS TCK.

TCK checks have been moved to the reactive-streams-tck-tests module, using plain TestNG, and running using a dedicated JUnit 5 engine.

Closes #782
@jponge jponge requested a review from cescoffier January 3, 2022 11:34
@jponge jponge added the enhancement New feature or request label Jan 3, 2022
@jponge jponge added this to the 1.3.0 milestone Jan 3, 2022
@jponge
Copy link
Member Author

jponge commented Jan 3, 2022

Note that the assumption is that no downstream project consumed reactive-streams-junit5-tck beyond Mutiny.

@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #793 (e77b021) into main (dea5025) will decrease coverage by 0.63%.
The diff coverage is n/a.

❗ Current head e77b021 differs from pull request most recent head b96f5a1. Consider uploading reports for the commit b96f5a1 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main     #793      +/-   ##
============================================
- Coverage     90.00%   89.36%   -0.64%     
+ Complexity     3011     2995      -16     
============================================
  Files           377      377              
  Lines         11891    11891              
  Branches       1500     1502       +2     
============================================
- Hits          10702    10626      -76     
- Misses          606      664      +58     
- Partials        583      601      +18     
Impacted Files Coverage Δ
...tiny/streams/stages/OnErrorResumeStageFactory.java 50.00% <0.00%> (-50.00%) ⬇️
...allrye/mutiny/streams/utils/WrappedSubscriber.java 60.00% <0.00%> (-40.00%) ⬇️
...rye/mutiny/streams/utils/CancellablePublisher.java 66.66% <0.00%> (-33.34%) ⬇️
...mallrye/mutiny/streams/utils/WrappedProcessor.java 78.94% <0.00%> (-21.06%) ⬇️
...rye/mutiny/streams/utils/ConnectableProcessor.java 52.70% <0.00%> (-17.57%) ⬇️
...utiny/operators/multi/MultiOnCancellationCall.java 76.19% <0.00%> (-14.29%) ⬇️
.../operators/multi/MultiSelectFirstUntilOtherOp.java 80.00% <0.00%> (-12.00%) ⬇️
...ava/io/smallrye/mutiny/helpers/HalfSerializer.java 77.77% <0.00%> (-11.12%) ⬇️
...lrye/mutiny/streams/stages/CancelStageFactory.java 70.00% <0.00%> (-10.00%) ⬇️
...rye/mutiny/operators/multi/MultiOnRequestCall.java 90.32% <0.00%> (-9.68%) ⬇️
... and 28 more

Copy link
Contributor

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo!

@cescoffier cescoffier merged commit b83b5db into main Jan 3, 2022
@cescoffier cescoffier deleted the refactor/tck branch January 3, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants