Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require the pom.properties file to be present on the classpath #1333

Closed
Azquelt opened this issue Dec 14, 2022 · 2 comments · Fixed by #1389
Closed

Don't require the pom.properties file to be present on the classpath #1333

Azquelt opened this issue Dec 14, 2022 · 2 comments · Fixed by #1389
Milestone

Comments

@Azquelt
Copy link
Contributor

Azquelt commented Dec 14, 2022

When we implement MP OpenAPI in open liberty, we repackage the org.eclipse.microprofile.openapi jar and generate new maven metadata so it does not contain the pom.properties file in the expected location.

Can we adapt the code added in #1269 to default to the latest version if this file is not found? (A different solution would also be fine, but this one seems the most straightforward.)

@MikeEdgar
Copy link
Member

we repackage the org.eclipse.microprofile.openapi jar and generate new maven metadata so it does not contain the pom.properties file in the expected location

Is your process flexible enough to drop a pom.properties in the expected location? Otherwise, maybe this could be a config property that isn't user-facing. Would that work?

@Azquelt
Copy link
Contributor Author

Azquelt commented Feb 6, 2023

Is your process flexible enough to drop a pom.properties in the expected location?

It is, but one of the uses of the maven metadata is to help someone looking at the jar understand what it is and where it came from. I don't want to drop in a second pom.properties with different information when the jar we build already has one.

Otherwise, maybe this could be a config property that isn't user-facing. Would that work?

This is a possibility. It would also be fine if it was read from a properties file on the classpath with a different name. I'd just like some way of overriding it which doesn't involve adding incorrect maven metadata to my jar.

MikeEdgar added a commit to MikeEdgar/smallrye-open-api that referenced this issue Mar 1, 2023
Fixes smallrye#1333

Signed-off-by: Michael Edgar <michael@xlate.io>
MikeEdgar added a commit to MikeEdgar/smallrye-open-api that referenced this issue Mar 1, 2023
Fixes smallrye#1333

Signed-off-by: Michael Edgar <michael@xlate.io>
MikeEdgar added a commit that referenced this issue Mar 2, 2023
#1389)

Fixes #1333

Signed-off-by: Michael Edgar <michael@xlate.io>
@MikeEdgar MikeEdgar added this to the 3.3.0 milestone Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants