Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for alternate properties file to determine MP OpenAPI spec level #1389

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Allow for alternate properties file to determine MP OpenAPI spec level #1389

merged 1 commit into from
Mar 2, 2023

Conversation

MikeEdgar
Copy link
Member

@MikeEdgar MikeEdgar commented Mar 1, 2023 •
edited
Loading

Fixes #1333

Allow MP OpenAPI specification version to be given via properties file io.smallrye.openapi.api.util.VersionUtil.properties on the classpath.

@MikeEdgar MikeEdgar added this to the 3.2.1 milestone Mar 1, 2023
@MikeEdgar
Copy link
Member Author

@Azquelt , please review and let me know if this option will work for #1333.

@MikeEdgar
Allow for alternate properties file to determine MP OpenAPI spec level
cb5c255 
Fixes smallrye#1333

Signed-off-by: Michael Edgar <michael@xlate.io>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Azquelt
Azquelt approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@Azquelt Azquelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this looks good to me, thank you.

@MikeEdgar MikeEdgar requested a review from phillip-kruger March 2, 2023 21:51
@MikeEdgar MikeEdgar merged commit 170c3db into smallrye:main Mar 2, 2023
@MikeEdgar MikeEdgar deleted the issue-1333 branch October 8, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillip-kruger phillip-kruger phillip-kruger approved these changes

@Azquelt Azquelt Azquelt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

Don't require the pom.properties file to be present on the classpath
3 participants
@MikeEdgar @Azquelt @phillip-kruger