Schema annotations 3.1 #1801
Merged
Schema annotations 3.1 #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In e83724a I made some of the scanner tests output the actual JSON document in the event of a failure because it was more helpful to me during development than configuring logging and finding the logs, but that part is not relevant to the actual changes and can be dropped if desired. |
Azquelt
force-pushed
the
schema-annotations-3.1
branch
from
693e2d3
to
1d7c0a0
Compare
This was referenced Apr 26, 2024
Azquelt
force-pushed
the
schema-annotations-3.1
branch
from
1d7c0a0
to
88d07fb
Compare
Include the full JSON output from the scanner when a test fails, to avoid needing to search the logs and enable debug logging.
Azquelt
force-pushed
the
schema-annotations-3.1
branch
from
88d07fb
to
54bfe93
Compare
Tests for: - if/then/else - allOf/anyOf/oneOf/not - dependentSchemas - prefixItems - contains/maxContains/minContains - propertyNames - patternProperties - contentEncoding - contentMediaType - contentSchema
Azquelt
force-pushed
the
schema-annotations-3.1
branch
from
54bfe93
to
fe8bd1b
Compare
|
CI will not run cleanly until eclipse/microprofile-open-api#601 is merged but I have built and run this change locally with no failures. |
MikeEdgar
approved these changes
May 7, 2024
- examples - comment - if/then/elseSchema - dependentSchemas - prefixItems - contains/minContains/maxContains - patternProperties - propertyNames - constValue - dependentRequired - contentEncoding/contentMediaType/contentSchema
Azquelt
force-pushed
the
schema-annotations-3.1
branch
from
fe8bd1b
to
617b831
Compare
|
@MikeEdgar we now have a good build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the
@Schemaand@SchemaPropertychanges from eclipse/microprofile-open-api#601.I haven't duplicated cases which are already covered by the TCK.