Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support summary attribute on Info annotation #1815

Merged

Conversation

benjamin-confino
Copy link
Contributor

This is part of the schema changes under eclipse/microprofile-open-api#584

Specifically it adds the attribute summary to the annotation Info, as per this issue eclipse/microprofile-open-api#435

I built these changes on a branch including the commits in this PR: #1801 - I don't think this PR depends on it, but I plan to wait for those commits to be delivered and main-4.0 to be in a compilable state for testing.

@benjamin-confino benjamin-confino marked this pull request as draft April 26, 2024 09:14
@benjamin-confino benjamin-confino force-pushed the schema-model-3.1-benjamin-2 branch from 5848e1b to 265c21a Compare May 8, 2024 21:53
@MikeEdgar MikeEdgar added this to the 4.0.0 milestone May 9, 2024
@benjamin-confino benjamin-confino changed the base branch from main-4.0 to jakarta May 9, 2024 08:53
@benjamin-confino benjamin-confino changed the base branch from jakarta to main-4.0 May 9, 2024 08:53
@benjamin-confino benjamin-confino marked this pull request as ready for review May 9, 2024 08:53
@benjamin-confino benjamin-confino force-pushed the schema-model-3.1-benjamin-2 branch from 265c21a to ea27df2 Compare May 9, 2024 09:59
Copy link
Member

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things to change, otherwise looking good.

@benjamin-confino benjamin-confino force-pushed the schema-model-3.1-benjamin-2 branch from ea27df2 to 6a43ff0 Compare May 9, 2024 13:10
Copy link
Member

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll wait for a new MP OpenAPI snapshot with the API changes to rerun the CI before merging.

@MikeEdgar MikeEdgar merged commit 73183db into smallrye:main-4.0 May 10, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants