Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AuthParams to OIDC struct #1802

Merged
merged 5 commits into from
Jun 12, 2024
Merged

add AuthParams to OIDC struct #1802

merged 5 commits into from
Jun 12, 2024

Conversation

jdoupe
Copy link
Contributor

@jdoupe jdoupe commented Apr 16, 2024

Name of feature:

Add "AuthParams" to OIDC provisioner.

Pain or issue this feature alleviates:

AuthParams (or "extra parameters for the authorization request") are sometimes a requirement for OIDC configurations. Someone had already added the capability as a command line parameter, but remote requests to a CA wouldn't be able to include any extra parameters.

Why is this important to the project (if not answered above):

Is there documentation on how to use this feature? If so, where?

Not absolutely sure where to update this, but it would entail the addition of an "authParams" key within an OIDC provisioner:
e.g.

                               "authParams": [
                                        "myextrakey=myextravalue"
                                ],

In what environments or workflows is this feature supported?

In what environments or workflows is this feature explicitly NOT supported (if any)?

Supporting links/other PRs/issues:

💔Thank you!

@CLAassistant
Copy link

CLAassistant commented Apr 16, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Apr 16, 2024
@hslatman hslatman requested a review from maraino April 16, 2024 17:16
@maraino
Copy link
Contributor

maraino commented Apr 16, 2024

Hi @jdoupe,

We will accept this contribution and smallstep/cli#1154, but they are not a complete PR as it does not allow configuring the provisioners in a database and a linked CA.

I've added the details for this in a similar PR, see #1796 (comment)

And we will work on this, but it can take some time, you can also send us a more complete PR.

@maraino
Copy link
Contributor

maraino commented Apr 16, 2024

Similar to the other PR, the workaround is adding `"auth-param" to the defaults.json so it sets those flags automatically.

@jdoupe
Copy link
Contributor Author

jdoupe commented Apr 16, 2024

@maraino,

Thanks for the feedback!

I've updated my branch here to include "Scopes" from #1796 along with the linkedca provisioner bits. And to that end, I also created a branch on smallstep/linkedca to address the proto changes.
(https://github.com/jdoupe/linkedca/tree/AuthParams).

I'll submit a PR for that when I get around to seeing if I can test the database and linked ca scenarios.

UPDATE: I'll also have to take a step back and update the CLI branch to accept scopes from the provisioner as well.

@jdoupe
Copy link
Contributor Author

jdoupe commented Apr 22, 2024

Confirmed functionality in "Remote Provisioner Management" configuration.

@jdoupe
Copy link
Contributor Author

jdoupe commented Apr 22, 2024

Linking related PR's for reference:
smallstep/linkedca#84
smallstep/cli#1154

Copy link
Contributor

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jdoupe, I will upgrade the linkedca dependency and merge.

@maraino maraino merged commit 634ece4 into smallstep:master Jun 12, 2024
7 of 13 checks passed
maraino added a commit that referenced this pull request Jun 12, 2024
This commit upgrades go.step.sm/linkedca with dependencies required by
#1802. It also fixes some linter warnings.
@maraino maraino mentioned this pull request Jun 12, 2024
@hslatman hslatman added this to the v0.26.2 milestone Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants