add AuthParams to token #1154
Merged
add AuthParams to token #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
needs triage
|
See my comment on smallstep/certificates#1802 |
|
Linking other related PR for easy reference: |
maraino
added a commit
that referenced
this pull request
Jun 12, 2024
This commit upgrades linkedca deependency that is required by #1154
Merged
maraino
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name of feature:
Read "AuthParams" from OIDC provisioner.
Pain or issue this feature alleviates:
AuthParams (or "extra parameters for the authorization request") are sometimes a requirement for OIDC configurations. Someone had already added the capability as a command line parameter, but remote requests to a CA wouldn't be able to include any extra parameters.
Why is this important to the project (if not answered above):
Is there documentation on how to use this feature? If so, where?
Not absolutely sure where to update this, but it would entail the addition of an "authParams" key within an OIDC provisioner:
e.g.
In what environments or workflows is this feature supported?
In what environments or workflows is this feature explicitly NOT supported (if any)?
Supporting links/other PRs/issues:
smallstep/certificates#1802
💔Thank you!