PLEX-1716 add observations wrapper with account context#1520
Merged
Conversation
apidiff results - backwards-incompatible changes detected ❌Module:
|
| Element | Change |
|---|---|
./pkg/capabilities/consensus/ocr3/datafeeds.SecureMintAggregatorConfig.Solana |
removed |
./pkg/capabilities/consensus/ocr3/datafeeds.SolanaConfig |
removed |
(Full summary: https://github.com/smartcontractkit/chainlink-common/actions/runs/17476015936/#summary-49635946786)
krehermann
reviewed
Sep 4, 2025
| }, | ||
| "encoder": { | ||
| "type": "string", | ||
| "enum": ["EVM", "ValueMap"] |
Contributor
There was a problem hiding this comment.
why did this change? where is this changed used in this pr?
Contributor
Author
There was a problem hiding this comment.
it's a batch of codependant PRs actually (from description)
Solana PR introduces ocr3cap borsh encoder
Core PR bumps solana + common and resolves breaking changes.
But I can separate them even further (1 PR for aggregator and 1 for encoder) but they are pretty small so I thought it's okay to do it in one PR.
vyzaldysanchez
previously approved these changes
Sep 4, 2025
jmank88
reviewed
Sep 4, 2025
pkg/capabilities/consensus/ocr3/datafeeds/securemint_aggregator.go
Outdated
Show resolved
Hide resolved
2726c09
jmank88
approved these changes
Sep 4, 2025
augustbleeds
approved these changes
Sep 4, 2025
cll-gg
added a commit
that referenced
this pull request
Sep 11, 2025
…)" This reverts commit 997205e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA
core PR
Solana PR