Skip to content

PLEX-1716 add observations wrapper with account context#1520

Merged
jmank88 merged 15 commits intomainfrom
PLEX-1716.pass_ctx_via_observations
Sep 4, 2025
Merged

PLEX-1716 add observations wrapper with account context#1520
jmank88 merged 15 commits intomainfrom
PLEX-1716.pass_ctx_via_observations

Conversation

@Unheilbar
Copy link
Contributor

@Unheilbar Unheilbar commented Sep 3, 2025

JIRA

  1. Move solana accounts context from Aggregator config to observations
  2. Add Borsh encoder to ocr3 capability

core PR
Solana PR

@github-actions
Copy link

github-actions bot commented Sep 3, 2025

apidiff results - backwards-incompatible changes detected ❌

Module: github-com-smartcontractkit-chainlink-common

Status: ❌ 2 incompatible, 2 compatible

Incompatible Changes (2)

Element Change
./pkg/capabilities/consensus/ocr3/datafeeds.SecureMintAggregatorConfig.Solana removed
./pkg/capabilities/consensus/ocr3/datafeeds.SolanaConfig removed

(Full summary: https://github.com/smartcontractkit/chainlink-common/actions/runs/17476015936/#summary-49635946786)

@Unheilbar Unheilbar marked this pull request as ready for review September 4, 2025 17:49
@Unheilbar Unheilbar requested a review from a team as a code owner September 4, 2025 17:49
},
"encoder": {
"type": "string",
"enum": ["EVM", "ValueMap"]
Copy link
Contributor

@krehermann krehermann Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did this change? where is this changed used in this pr?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a batch of codependant PRs actually (from description)
Solana PR introduces ocr3cap borsh encoder
Core PR bumps solana + common and resolves breaking changes.
But I can separate them even further (1 PR for aggregator and 1 for encoder) but they are pretty small so I thought it's okay to do it in one PR.

vyzaldysanchez
vyzaldysanchez previously approved these changes Sep 4, 2025
@Unheilbar Unheilbar requested a review from krehermann September 4, 2025 18:26
@jmank88 jmank88 merged commit 0bc8c47 into main Sep 4, 2025
21 of 22 checks passed
@jmank88 jmank88 deleted the PLEX-1716.pass_ctx_via_observations branch September 4, 2025 21:14
cll-gg added a commit that referenced this pull request Sep 11, 2025
This was referenced Sep 11, 2025
cll-gg added a commit that referenced this pull request Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants