Add WT and DeriveRemaining capability#1311
Merged
Conversation
* add cache config * add rest of remaining accounts for data feed cache report
Unheilbar
temporarily deployed
to
integration
GitHub Actions
Inactive
Unheilbar
temporarily deployed
to
integration
GitHub Actions
Inactive
Unheilbar
temporarily deployed
to
integration
GitHub Actions
Inactive
Unheilbar
temporarily deployed
to
integration
GitHub Actions
Inactive
Unheilbar
temporarily deployed
to
integration
GitHub Actions
Inactive
augustbleeds
previously approved these changes
Sep 4, 2025
Contributor
augustbleeds
left a comment
augustbleeds
left a comment
There was a problem hiding this comment.
looks good! no blocking comments
|
|
||
| chainName, err := chainselectors.SolanaNameFromChainId(chainID) | ||
| if err == nil { | ||
| wtID, err := writetarget.NewWriteTargetID("", chainName, chainID, "1.0.0") |
Contributor
There was a problem hiding this comment.
this is interesting, why do we use the write target name?
|
|
||
| transactionID := txID.String() | ||
| options := []utils.SetTxConfig{txmutils.SetEstimateComputeUnitLimit(false), txmutils.SetComputeUnitLimit(500_000)} | ||
| if err := ts.txm.Enqueue(ctx, ts.accounts.forwarderProgramID.String(), tx, &transactionID, blockhash.Value.LastValidBlockHeight, options...); err != nil { |
Contributor
There was a problem hiding this comment.
we can add a todo for simulating the tx to estimate the compute units. we don't need to do it now since we're only updating one value
augustbleeds
reviewed
Sep 4, 2025
| accountCtxHash = "account_context_hash" | ||
| ) | ||
|
|
||
| func NewEncoder(config *values.Map) (consensustypes.Encoder, error) { |
Unheilbar
temporarily deployed
to
integration
GitHub Actions
Inactive
Unheilbar
temporarily deployed
to
integration
GitHub Actions
Inactive
Unheilbar
temporarily deployed
to
integration
GitHub Actions
Inactive
Unheilbar
temporarily deployed
to
integration
GitHub Actions
Inactive
Unheilbar
temporarily deployed
to
integration
GitHub Actions
Inactive
Unheilbar
temporarily deployed
to
integration
GitHub Actions
Inactive
Unheilbar
temporarily deployed
to
integration
GitHub Actions
Inactive
Unheilbar
temporarily deployed
to
integration
GitHub Actions
Inactive
Unheilbar
temporarily deployed
to
integration
GitHub Actions
Inactive
Unheilbar
temporarily deployed
to
integration
GitHub Actions
Inactive
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces:
Core PR with E2E test: smartcontractkit/chainlink#19091
Core PR with current ref: smartcontractkit/chainlink#19224
Common PR with encoder support: smartcontractkit/chainlink-common#1520
depends on:#1307