Use canonical json for JSON RPC request and response marshaling#1610
Merged
prashantkumar1982 merged 3 commits intomainfrom Oct 13, 2025
Merged
Use canonical json for JSON RPC request and response marshaling#1610prashantkumar1982 merged 3 commits intomainfrom
prashantkumar1982 merged 3 commits intomainfrom
Conversation
|
👋 DeividasK, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
✅ API Diff Results - No breaking changes |
DeividasK
had a problem deploying
to
integration
GitHub Actions
Failure
DeividasK
had a problem deploying
to
integration
GitHub Actions
Failure
DeividasK
had a problem deploying
to
integration
GitHub Actions
Failure
DeividasK
changed the title
cedric-cordenier
approved these changes
Oct 13, 2025
jmank88
reviewed
Oct 13, 2025
| "fmt" | ||
| "strings" | ||
|
|
||
| canonicaljson "github.com/gibson042/canonicaljson-go" |
Contributor
There was a problem hiding this comment.
Can we use the standard library json/v2 instead of a third party? https://pkg.go.dev/encoding/json/v2
Contributor
There was a problem hiding this comment.
Er that is still experimental this release, but it is an embedding of this package: https://pkg.go.dev/github.com/go-json-experiment/json
prashantkumar1982
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to ensure consistency in request and response marshaling.