Use jsonrpc2.Request digest method#19845
Merged
Conversation
product-security-plaid-production
bot
requested review from
justinkaseman,
pavel-raykov and
shileiwill
shileiwill
previously approved these changes
Oct 10, 2025
| defer r.clearExpiredAuthorizedRequests() | ||
| r.lggr.Infow("AuthorizeRequest", "method", req.Method, "requestID", req.ID) | ||
| digest, err := vaulttypes.DigestForRequest(req) | ||
| requestDigest, err := req.Digest() |
Contributor
There was a problem hiding this comment.
Ack, this is the core change. we removed our customized DigestForRequest() and use the default Digest() from jsonrpc.
justinkaseman
previously approved these changes
Oct 10, 2025
…79-08-request-digest-collisions # Conflicts: # core/capabilities/vault/request_authorizer.go # core/capabilities/vault/request_authorizer_test.go # core/services/workflows/syncer/v2/workflow_syncer_v2_test.go # system-tests/tests/smoke/cre/v2_vault_don_test.go
DeividasK
dismissed stale reviews from justinkaseman and shileiwill
via
713a415
…79-08-request-digest-collisions
pavel-raykov
previously approved these changes
Oct 13, 2025
DeividasK
commented
Oct 14, 2025
| Params: nil, | ||
| } | ||
| isAuthorized, _, err := auth.AuthorizeRequest(context.Background(), invalidReq) | ||
| require.ErrorContains(t, err, "unauthorized method: invalid-method") |
Contributor
Author
There was a problem hiding this comment.
Whether the method is valid is checked in the handler, not the authorizer.
|
pavel-raykov
approved these changes
Oct 14, 2025
cedric-cordenier
approved these changes
Oct 14, 2025
DeividasK
deleted the
PRIV-217-audit-cl-79-08-request-digest-collisions
branch
This was referenced Oct 14, 2025
This was referenced Oct 23, 2025
This was referenced Nov 7, 2025
This was referenced Nov 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: