Skip to content

beholder: exposes chipingress client #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmank88 merged 7 commits into from
Oct 28, 2025
Merged

beholder: exposes chipingress client #1647

jmank88 merged 7 commits into from
Oct 28, 2025

Conversation

@pkcll
Copy link
Contributor

@pkcll pkcll commented Oct 24, 2025 •
edited
Loading

What

  • remove chipingress wrapper
  • expose chipingress client directly
  • set chip-ingress noop client for beholder noop client

Related PR's

Why

This is prep work for OTI to chip-ingress migration
OTI migration requires access to chipingress PublishBatch method

@pkcll pkcll changed the title Infoplat 2731 common beholder expose chip client beholder exposes chipingress client Oct 24, 2025
@github-actions
Copy link

github-actions bot commented Oct 24, 2025 •
edited
Loading

⚠️ API Diff Results - Breaking changes detected

📦 Module: github-com-smartcontractkit-chainlink-common

🔴 Breaking Changes (4)

pkg/beholder (2)

  • ChipIngressClient — 🗑️ Removed

  • NewChipIngressClient — 🗑️ Removed

pkg/beholder.BeholderClient (1)
  • Chip — Type changed:
  - ChipIngressClient
  + github.com/smartcontractkit/chainlink-common/pkg/chipingress.Client
)
pkg/beholder.Client (1)
  • Chip — Type changed:
  - ChipIngressClient
  + github.com/smartcontractkit/chainlink-common/pkg/chipingress.Client
)

📄 View full apidiff report

@pkcll pkcll changed the title beholder exposes chipingress client beholder: exposes chipingress client Oct 24, 2025
This was referenced Oct 24, 2025
Merged
Merged
pkcll
pkcll commented Oct 27, 2025
View reviewed changes
pkcll
pkcll commented Oct 27, 2025
View reviewed changes
pkg/beholder/chip_client.go
Copy link
Contributor Author

@pkcll pkcll Oct 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove wrapper ChipIngressClient interface, expose reference to chipingress.Client interface directly from beholder client (see here)

@pkcll
Merge branch 'main' of github.com:smartcontractkit/chainlink-common i…
5539a44 
…nto INFOPLAT-2731-common-beholder-expose-chip-client
@pkcll pkcll marked this pull request as ready for review October 27, 2025 16:45
@pkcll pkcll requested review from a team as code owners October 27, 2025 16:45
@pkcll pkcll force-pushed the INFOPLAT-2731-common-beholder-expose-chip-client branch from 0ac39a9 to fe3b522 Compare October 28, 2025 13:46
jmank88
jmank88 previously approved these changes Oct 28, 2025
View reviewed changes
@pkcll pkcll requested a review from hendoxc October 28, 2025 14:29
@pkcll
chipingress: add RegisterSchemas method and noop client (#1646)
a6e6622 
* chipingress: add RegisterSchemas method; add noop client implementation

* export chipingress noop client
@jmank88 jmank88 merged commit 61a523e into main Oct 28, 2025
17 of 22 checks passed
@jmank88 jmank88 deleted the INFOPLAT-2731-common-beholder-expose-chip-client branch October 28, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmank88 jmank88 jmank88 approved these changes

@kirqz23 kirqz23 kirqz23 approved these changes

@krehermann krehermann Awaiting requested review from krehermann

@hendoxc hendoxc Awaiting requested review from hendoxc

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pkcll @jmank88 @kirqz23