Wire up ChIP ingress client for TelemetryIngress #20063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkcll
force-pushed
the
INFOPLAT-2731-telemetry-wire-up-chip-ingress
branch
2 times, most recently
from
e6e8551 to
753019d
Compare
product-security-plaid-production
bot
requested review from
ChrisAmora,
cedric-cordenier and
kirqz23
pkcll
commented
Oct 28, 2025
| SendTimeout *commonconfig.Duration | ||
| UseBatchSend *bool | ||
| Endpoints []TelemetryIngressEndpoint `toml:",omitempty"` | ||
| ChipIngressEnabled *bool |
Collaborator
Author
There was a problem hiding this comment.
Flag to enable OTI telemetry ingress via ChIP Ingress
pkcll
commented
Oct 28, 2025
| useBatchSend bool | ||
| MonitoringEndpointGenerator MonitoringEndpointGenerator | ||
|
|
||
| chipIngressClient chipingress.Client |
Collaborator
Author
There was a problem hiding this comment.
Add reference to chip ingress client to be used for OTI telemetry ingress
pkcll
commented
Oct 28, 2025
| globalLogger.Info("ChIP Ingress is enabled for telemetry") | ||
| chipIngressClient = beholder.GetClient().Chip | ||
| } | ||
| telemetryManager := telemetry.NewManager(cfg.TelemetryIngress(), csaKeystore, globalLogger, chipIngressClient) |
Collaborator
Author
There was a problem hiding this comment.
Wire up chip ingress client for OTI telemetry ingress Manager
hendoxc
previously approved these changes
Oct 28, 2025
jmank88
reviewed
Oct 28, 2025
jmank88
reviewed
Oct 28, 2025
- Add chipIngressClient field to telemetry Manager struct - Pass chipingress.Client to NewManager constructor - Add ChipIngressEnabled option to TelemetryIngress config
pkcll
force-pushed
the
INFOPLAT-2731-telemetry-wire-up-chip-ingress
branch
from
3fcc3b7 to
6cd7428
Compare
|
jmank88
approved these changes
Oct 30, 2025
patrickhuie19
approved these changes
Oct 30, 2025
patrickhuie19
deleted the
INFOPLAT-2731-telemetry-wire-up-chip-ingress
branch
This was referenced Oct 29, 2025
This was referenced Nov 7, 2025
This was referenced Nov 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Related PR's
Why
This is prep work for OTI Telemetry migration to ChIP ingress