pkg/settings: fix SettingMap.GetOrDefault#1730
Merged
Conversation
|
👋 jmank88, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
✅ API Diff Results - No breaking changes |
jmank88
commented
Dec 10, 2025
| } | ||
| if g == nil { | ||
| //TODO confirm via test | ||
| valueOrDefault := func() (T, error) { |
Contributor
Author
There was a problem hiding this comment.
This logic was only applied when the SettingsGetter was nil, but even if DefaultGetter is nil (like our tests), core wraps it in an AtomicSettings getter, so it was bypassed. Instead we need to apply it in every default case.
jmank88
force-pushed
the
chains-allowed-fix
branch
from
b48d47f to
0d3c278
Compare
krehermann
approved these changes
Dec 10, 2025
bolekk
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/PLEX-2121
Fix for #1727
Supports: