Skip to content

core/services/workflows/v2: enforce PerWorkflow.ChainAllowed gate#20548

Merged
jmank88 merged 2 commits intodevelopfrom
chains-allowed
Dec 11, 2025
Merged

core/services/workflows/v2: enforce PerWorkflow.ChainAllowed gate#20548
jmank88 merged 2 commits intodevelopfrom
chains-allowed

Conversation

@jmank88
Copy link
Contributor

@jmank88 jmank88 commented Dec 7, 2025

https://smartcontract-it.atlassian.net/browse/PLEX-2110

This PR enforces the cre setting PerWorkflow.ChainAllowed to gate chain capability calls and trigger subscriptions.

Note: This make real chains not allowed by default, so deployed settings must be updated before upgrading nodes.

Requires:

Supports:

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

trunk-io[bot]

This comment was marked as outdated.

trunk-io[bot]

This comment was marked as outdated.

@jmank88 jmank88 force-pushed the chains-allowed branch 2 times, most recently from 0b668ed to 9509af3 Compare December 9, 2025 18:45
@jmank88 jmank88 requested a review from dhaidashenko December 9, 2025 18:46
trunk-io[bot]

This comment was marked as outdated.

@jmank88 jmank88 force-pushed the chains-allowed branch 2 times, most recently from fe7d7ed to 295b62d Compare December 9, 2025 20:22
trunk-io[bot]

This comment was marked as outdated.

@jmank88 jmank88 force-pushed the chains-allowed branch 2 times, most recently from 84fc31d to e80c12e Compare December 9, 2025 21:32
trunk-io[bot]

This comment was marked as outdated.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

CORA - Analysis Skipped

Reason: The number of code owners (4) is less than the minimum required (5) and/or the number of CODEOWNERS entries with changed files (6) is less than the minimum required (2).

trunk-io[bot]

This comment was marked as outdated.

@jmank88 jmank88 force-pushed the chains-allowed branch 2 times, most recently from d4a108b to c77f60b Compare December 10, 2025 00:14
@trunk-io
Copy link

trunk-io bot commented Dec 10, 2025

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@jmank88 jmank88 force-pushed the chains-allowed branch 2 times, most recently from d200750 to 16fb1a3 Compare December 10, 2025 01:07
trunk-io[bot]

This comment was marked as outdated.

trunk-io[bot]

This comment was marked as outdated.

trunk-io[bot]

This comment was marked as outdated.

Comment on lines +17 to +18
# Temporary reduction in concurrent packages to reduce RAM usage
GO_TEST_FLAGS="$GO_TEST_FLAGS -p=4"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @erikburt

@jmank88
Copy link
Contributor Author

jmank88 commented Dec 11, 2025

Core CI failure is unrelated - likely resouce exhaustion? exit code 143

Had to push an irrelevant update to get past this - please re-ack ASAP 🙏

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
4.34% Technical Debt Ratio on New Code (required ≤ 4%)

See analysis details on SonarQube

@jmank88 jmank88 changed the title core/services/workflows/v2: enforce PerWorkflow.ChainsAllowed gate core/services/workflows/v2: enforce PerWorkflow.ChainAllowed gate Dec 11, 2025
@jmank88 jmank88 requested review from a team, cedric-cordenier and ettec December 11, 2025 14:13
@jmank88 jmank88 added this pull request to the merge queue Dec 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2025
@jmank88 jmank88 added this pull request to the merge queue Dec 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2025
@jmank88 jmank88 added this pull request to the merge queue Dec 11, 2025
Merged via the queue into develop with commit 2bbb0de Dec 11, 2025
226 of 228 checks passed
@jmank88 jmank88 deleted the chains-allowed branch December 11, 2025 15:20
jmank88 added a commit that referenced this pull request Dec 11, 2025
…0548)

* core/services/workflows/v2: enforce PerWorkflow.ChainAllowed gate

* tools/bin/go_core_test: use -p 4 to reduce RAM
jmank88 added a commit that referenced this pull request Dec 11, 2025
…0548) [cherry-pick] (#20601)

core/services/workflows/v2: enforce PerWorkflow.ChainAllowed gate (#20548)

* core/services/workflows/v2: enforce PerWorkflow.ChainAllowed gate

* tools/bin/go_core_test: use -p 4 to reduce RAM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants