core/services/workflows/v2: enforce PerWorkflow.ChainAllowed gate (#20548) [cherry-pick]#20601
Conversation
…0548) * core/services/workflows/v2: enforce PerWorkflow.ChainAllowed gate * tools/bin/go_core_test: use -p 4 to reduce RAM
product-security-plaid-production
bot
requested review from
Tofel and
vyzaldysanchez
|
I see you updated files related to
|
![trunk-io[bot]](https://avatars.githubusercontent.com/in/120106?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔴 Test Results: Unrelated Failure
Affected failures:
- TestBuildProposalFromBatchesV2 (Workflow Run: Core Tests (go_core_ccip_deployment_tests))
- TestAddRemoteChainWithMcms (Workflow Run: Core Tests (go_core_ccip_deployment_tests))
- TestDeployMCMSWithTimelockV2 (Workflow Run: Core Tests (go_core_ccip_deployment_tests))
- TestConfigureForwarder (Workflow Run: Core Tests (go_core_ccip_deployment_tests))
- Workflow Run: Run CCIP integration In Memory Tests For PR / smoke/ccip/ccip_messaging_test.go:Test_CCIPMessaging_EVM2Solana
- Workflow Run: Run CCIP integration In Memory Tests For PR / smoke/ccip/ccip_messaging_test.go:Test_CCIPMessaging_Solana2EVM
- Workflow Run: Run CCIP integration In Memory Tests For PR / smoke/ccip/ccip_cs_rmn_curse_uncurse_test.go:TestRMNCurseConfigValidate
- Workflow Run: Run CCIP integration In Memory Tests For PR / smoke/ccip/ccip_cs_rmn_curse_uncurse_test.go:TestRMNCurseOneConnectedLanesSolana
- Workflow Run: Run CCIP integration In Memory Tests For PR / smoke/ccip/ccip_sui_messaging_test.go:Test_CCIP_Messaging_Sui2EVM
- Workflow Run: Run CCIP integration In Memory Tests For PR / smoke/ccip/ccip_cs_rmn_curse_uncurse_test.go:TestRMNUncurseBypass
- Workflow Run: Run CCIP integration In Memory Tests For PR / smoke/ccip/ccip_cs_rmn_curse_uncurse_test.go:TestRMNCurseOneConnectedLanes
- Workflow Run: Run CCIP integration In Memory Tests For PR / smoke/ccip/ccip_cs_rmn_curse_uncurse_test.go:TestRMNCurseOneConnectedLanesLaneOnlyOnSource
- Workflow Run: Run CCIP integration In Memory Tests For PR / smoke/ccip/ccip_token_transfer_test.go:*
- Workflow Run: Integration Tests
What Broke
These failures appear to be unrelated to the changes in this PR. The majority are caused by transient external network or service issues, such as TLS handshake timeouts and HTTP 503 Service Unavailable errors from GitHub, which prevented the download of necessary release artifacts (e.g., Solana, chainlink-ccip, SUI). Additionally, some failures are due to known test flakiness or unhandled errors from new gate limiting logic.
Autofix Options
You can use our MCP server to get AI assistance with debugging and fixing these failures.
- Use MCP in your IDE to debug the issue. Try
Help me fix CI failures from pKMoVy5Wto get started.
There was a problem hiding this comment.
🔴 Test Results: Go Test Parallelism Reduced
Affected failures:
- Workflow Run: Integration Tests
What Broke
The reduction of concurrent Go test packages to 4 in the go_core_tests script caused the integration tests to fail.
Proposed Fixes
Remove the lines that limit test parallelism in the go_core_tests script.
- # Temporary reduction in concurrent packages to reduce RAM usage
- GO_TEST_FLAGS="$GO_TEST_FLAGS -p=4"Autofix Options
You can apply the proposed fixes directly to your branch. Try the following:
- Comment
/trunk stack-fix INjvpxneto generate a stacked PR with the proposed fixes. - Use MCP in your IDE to fix the issue. Try
Help me fix CI failures from INjvpxneto get started.
Tip
Get Better Results: This CI job is not uploading test reports. Adding structured test reports enables more precise, test-level analysis with better root cause identification and more targeted fix recommendations.
👉🏻 Learn how to upload test results.
There was a problem hiding this comment.
🔴 Test Results: Dependency Incompatibility, Solana
Affected tests:
- TestSetConfigMCMSV2Solana (Workflow Run: Core Tests (go_core_ccip_deployment_tests))
- TestValidateConfigureTokenPoolContractsForSolana (Workflow Run: Core Tests (go_core_ccip_deployment_tests))
What Broke
Updates to the github.com/smartcontractkit/chainlink-common dependency introduced incompatibilities. These led to issues such as HTTP client failures (503 status code) when downloading Solana artifacts and malformed account data during Solana Timelock program initialization.
Proposed Fixes
Add a User-Agent header to HTTP requests for Solana artifact downloads to improve compatibility with GitHub's release server, and update the chainlink-ccip module to a compatible version, then synchronize go.mod and go.sum.
go get -u github.com/smartcontractkit/chainlink-ccip
go mod tidy \tif err != nil {
\t return err
\t}
+ \treq.Header.Set("User-Agent", "chainlink-artifact-downloader/1.0")
\tres, err := (&http.Client{}).Do(req)
\tif err != nil {Autofix Options
You can use our MCP server to get AI assistance with debugging and fixing these failures.
- Use MCP in your IDE to debug the issue. Try
Help me fix CI failures from cojHITFhto get started.
jmank88
deleted the
2.31.0-cre-2bbb0de3a0846e1f034dc21aecf92029038afc15
branch
|
3 participants
#20548
2bbb0de