Update FixtureChainID #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vreff
force-pushed
the
bump-go-ethereum
branch
from
98579ce to
6a356f0
Compare
product-security-plaid-test
bot
requested review from
RensR,
Unheilbar and
chudilka1
Collaborator
|
Can we add codeowners for the |
Unheilbar
previously approved these changes
Sep 3, 2025
dhaidashenko
previously approved these changes
Sep 3, 2025
jmank88
reviewed
Sep 3, 2025
jmank88
approved these changes
Sep 3, 2025
vreff
requested review from
Unheilbar,
dhaidashenko,
ibrajer and
pavel-raykov
pavel-raykov
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking up from: #17
Update FixtureChainID to avoid using an invalid chain ID (0) that causes a panic in newer versions of go-ethereum. This should unblock us from bumping go-ethereum in a subsequent PR.
There are quite a few places where a zero chain ID is implied by
evmChainIDorchainIDsimply being absent from structs we declare. Now the chain ID is overtly declared in these structs to be ourFixtureChainID.