Remove use of zero chain ID. #19186
Merged
Remove use of zero chain ID. #19186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-security-plaid-test
bot
requested review from
dhaidashenko,
george-dorin,
gustavogama-cll and
ibrajer
ibrajer
previously approved these changes
Sep 3, 2025
dhaidashenko
approved these changes
Sep 3, 2025
dhaidashenko
previously approved these changes
Sep 3, 2025
Collaborator
dhaidashenko
left a comment
dhaidashenko
left a comment
There was a problem hiding this comment.
Just a friendly reminder to update refenrece to chainlink-evm once it's merged
jmank88
reviewed
Sep 3, 2025
|
jmank88
reviewed
Sep 3, 2025
| peerID := cltest.DefaultP2PPeerID | ||
| ocrKeyID := cltest.DefaultOCRKeyBundleID | ||
| jobSpecText := fmt.Sprintf(ocrJobSpecText, testutils.NewAddress().Hex(), peerID, ocrKeyID, transmitterAddress.Hex(), b1, b2) | ||
| jobSpecText := fmt.Sprintf(ocrJobSpecText, testutils.NewAddress().Hex(), testutils.FixtureChainID.String(), peerID, ocrKeyID, transmitterAddress.Hex(), b1, b2) |
Contributor
There was a problem hiding this comment.
nit/ You don't have to call String() with %s:
Suggested change
| jobSpecText := fmt.Sprintf(ocrJobSpecText, testutils.NewAddress().Hex(), testutils.FixtureChainID.String(), peerID, ocrKeyID, transmitterAddress.Hex(), b1, b2) | |
| jobSpecText := fmt.Sprintf(ocrJobSpecText, testutils.NewAddress().Hex(), testutils.FixtureChainID, peerID, ocrKeyID, transmitterAddress.Hex(), b1, b2) |
jmank88
approved these changes
Sep 3, 2025
cedric-cordenier
approved these changes
Sep 3, 2025
This was referenced Sep 3, 2025
This was referenced Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: smartcontractkit/chainlink-evm#214
This PR removes the use of chain ID:
0. Instead, it uses theFixtureChainID&NullClientChainIDfromchainlink-evm, which uses a value that is unlikely to be used by a production chain.This change is necessary due to a breaking change in
go-ethereumthat disallows using0as the chain ID: https://github.com/ethereum/go-ethereum/blob/master/core/types/transaction_signing.go#L193. In order to bumpgo-ethereum, this change needs to be applied.