Skip to content

Added EAStatusEvent to proto reg #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pkcll merged 12 commits into from
Aug 19, 2025
Merged

Added EAStatusEvent to proto reg #138

pkcll merged 12 commits into from
Aug 19, 2025

Conversation

@Fletch153
Copy link
Contributor

@Fletch153 Fletch153 commented Aug 6, 2025 •
edited by atlassian bot
Loading

What

  • Added bridge_status.proto schema to Beholder telemetry system
  • Integrated BridgeStatusEvent message into both staging and production Beholder configurations

Why

  • Enable telemetry collection for external adapter bridge status monitoring
  • Provide comprehensive bridge health and configuration data to the Beholder system
  • Support monitoring of bridge uptime, endpoints, configuration, and associated jobs
  • Enhance observability for external adapter infrastructure
  • See DF-21668

Notes

@Fletch153 Fletch153 requested review from a team as code owners August 6, 2025 15:17
@changeset-bot
Copy link

changeset-bot bot commented Aug 6, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 98a4b79

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link

github-actions bot commented Aug 6, 2025

👋 Fletch153, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions

This comment was marked as outdated.

Sign in to view
@Fletch153 Fletch153 force-pushed the feature/DF-21286/add_ea_telemetry_protos branch 3 times, most recently from 85618b5 to fc81ec8 Compare August 6, 2025 15:23
@Fletch153 Fletch153 force-pushed the feature/DF-21286/add_ea_telemetry_protos branch from fc81ec8 to 715e340 Compare August 6, 2025 15:25
@pkcll pkcll requested a review from a team as a code owner August 7, 2025 20:36
@pkcll
Add nested message types from bridge_status.proto before BridgeStatus…
3a4f9be 
…Event

   - Register JobInfo, RuntimeInfo, MetricsInfo, EndpointInfo, and ConfigurationItem entities
@pkcll pkcll force-pushed the feature/DF-21286/add_ea_telemetry_protos branch from 4dc81ad to 3a4f9be Compare August 7, 2025 20:54
pkcll
pkcll previously approved these changes Aug 13, 2025
View reviewed changes
pkcll
pkcll reviewed Aug 13, 2025
View reviewed changes
platform/go.mod Outdated
@@ -0,0 +1,5 @@
module github.com/smartcontractkit/chainlink-protos/platform
Copy link
Contributor

@pkcll pkcll Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

platform is a domain name for the protos emitted via Beholder.

Tofel
Tofel previously approved these changes Aug 13, 2025
View reviewed changes
patrickhuie19
patrickhuie19 requested changes Aug 13, 2025
View reviewed changes
workflows/bridge_status/v1/bridge_status.proto Outdated
option go_package = "github.com/smartcontractkit/chainlink-protos/platform/bridge_status/v1";

// BridgeStatusEvent represents the status data from an External Adapter
message BridgeStatusEvent {
Copy link
Contributor

@patrickhuie19 patrickhuie19 Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This format will break the local-cre, and will require a decomposition similar to: #145 and needs to be supported by smartcontractkit/chainlink-testing-framework#2036 (cc @Tofel )

Copy link
Contributor

@pkcll pkcll Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Redpanda should support this as long as the root level proto is on the first place.

Copy link
Contributor

@Tofel Tofel Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved it assuming that we will only ever send BridgeStatusEvent messages. If that's the case it should work with the local CRE.

Copy link
Contributor

@cll-gg cll-gg Aug 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that the node is only sending BridgeStatusEvent messages (code here). This was added in smartcontractkit/chainlink#18634

@cll-gg cll-gg requested a review from patrickhuie19 August 14, 2025 11:00
patrickhuie19
patrickhuie19 reviewed Aug 14, 2025
View reviewed changes
workflows/bridge_status/v1/bridge_status.proto Outdated

package bridge_status.v1;

option go_package = "github.com/smartcontractkit/chainlink-protos/platform/bridge_status/v1";
Copy link
Contributor

@patrickhuie19 patrickhuie19 Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the go code belongs outside of the workflows domain, I'd suggest that this proto follow it. platform isn't the most meaningful domain name, if there's a domain more tightly scoped to the intent behind this change, let's use that.

Copy link
Contributor

@cll-gg cll-gg Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's about getting more visibility into EAs, that's why we picked platform, since it's important for multiple products. Open to alternatives though!
See also DF-21668 for more context.

Copy link
Contributor

@patrickhuie19 patrickhuie19 Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @cll-gg if you are owning this now

Copy link
Contributor

@patrickhuie19 patrickhuie19 Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data-feeds could be a more meaningful name than platform

@skudasov skudasov self-requested a review August 19, 2025 19:55
@pkcll pkcll removed the request for review from mchain0 August 19, 2025 20:56
@pkcll pkcll enabled auto-merge (squash) August 19, 2025 20:57
@pkcll pkcll disabled auto-merge August 19, 2025 20:57
@pkcll pkcll merged commit e4d35db into main Aug 19, 2025
18 of 19 checks passed
@pkcll pkcll deleted the feature/DF-21286/add_ea_telemetry_protos branch August 19, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tofel Tofel Tofel left review comments

@cll-gg cll-gg cll-gg left review comments

@skudasov skudasov skudasov approved these changes

@patrickhuie19 patrickhuie19 patrickhuie19 approved these changes

@ecPablo ecPablo ecPablo approved these changes

@pkcll pkcll pkcll approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Fletch153 @skudasov @patrickhuie19 @Tofel @cll-gg @ecPablo @pkcll