Skip to content

decomposing #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
patrickhuie19 merged 1 commit into from
Aug 11, 2025
Merged

decomposing #145

patrickhuie19 merged 1 commit into from
Aug 11, 2025

Conversation

@patrickhuie19
Copy link
Contributor

@patrickhuie19 patrickhuie19 commented Aug 11, 2025 •
edited
Loading

Redpanda schema registry expects one file per message, and it will only grab the top message on the file

@patrickhuie19 patrickhuie19 requested review from a team as code owners August 11, 2025 17:56
@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 60de869

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link

github-actions bot commented Aug 11, 2025

👋 patrickhuie19, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link

github-actions bot commented Aug 11, 2025 •
edited
Loading

The latest Buf updates on your PR. Results from workflow Regenerate Protobuf Files / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed❌ failed (14)✅ passed❌ failed (9)Aug 11, 2025, 5:57 PM

@patrickhuie19 patrickhuie19 force-pushed the chore/v2-workflow-events-decompose branch from 6abd8d2 to 60de869 Compare August 11, 2025 17:57
@patrickhuie19 patrickhuie19 merged commit 6ca363b into main Aug 11, 2025
11 of 12 checks passed
@patrickhuie19 patrickhuie19 deleted the chore/v2-workflow-events-decompose branch August 11, 2025 18:08
patrickhuie19
patrickhuie19 commented Aug 11, 2025
View reviewed changes
workflows/workflows/v2/transaction_info.proto

option go_package = "github.com/smartcontractkit/chainlink-protos/workflows/go/v2";

// DEPLOYMENT
Copy link
Contributor Author

@patrickhuie19 patrickhuie19 Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will cleanup in a future pr

@patrickhuie19 patrickhuie19 mentioned this pull request Aug 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@EasterTheBunny EasterTheBunny EasterTheBunny approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@patrickhuie19 @EasterTheBunny