BCFR-888 LP support chains that have not reached finality yet #14366
Conversation
dhaidashenko
changed the title
| finalizedBN = 1 | ||
| } | ||
| lp.lggr.Debugw("Latest blocks read from chain", "latest", latest.Number, "finalized", finalizedBN) | ||
| return latest, finalizedBN, nil |
There was a problem hiding this comment.
In the past, we've just required all tests to make sure the chain has reached finality before running. Is there a test where this is infeasible?
If we're adding support for chains shorter than finality depth, then we should remove this comment saying it's not supported:
https://github.com/smartcontractkit/chainlink/pull/14366/files#diff-08d58e904d709d1cb1a2ba1e99cce7dfd594bbf7369f05d3b187e10316dc5babL606-L612
Also, are you sure there aren't other places where we make that assumption... does this change fix it everywhere?
There was a problem hiding this comment.
In the past, we've just required all tests to make sure the chain has reached finality before running. Is there a test where this is infeasible?
CCIP load tests do not follow this requirement. Also it's not feasible on chains with large finality depth as it might take hours for test to start generating load.
If we're adding support for chains shorter than finality depth, then we should remove this comment saying it's not supported:
Nice catch. Removed
Also, are you sure there aren't other places where we make that assumption... does this change fix it everywhere?
Yes, this seems to be the only place where LP makes assumptions on min chain length.
…in parallel to prevent db deadlock
|
| @@ -90,7 +90,6 @@ func Test_ContractTransmitter_TransmitWithoutSignatures(t *testing.T) { | |||
| for _, tc := range testCases { | |||
| t.Run(tc.name, func(t *testing.T) { | |||
| tc := tc | |||
| t.Parallel() | |||
There was a problem hiding this comment.
This is required as now LP can fetch events even if the latest finalized block is genesis block. The test starts multiple instances of the LogPoller with the same chainID. Each LogPoller tries to insert observed blocks, but catches a deadlock on DB level as they are all connected to the same db and try to insert the same block. I was expecting that ON CONFLICT DO NOTHING will prevent the deadlock, but it does not seem to be the case
…develop * origin/develop: (233 commits) update Smoke Test TestAutomationBasic to load pre-deployed contracts if given (#14537) CCIP-2881 USDC Reader integration tests (#14516) [TT-1624] link PR to solidity review issue (#14521) Fix skipped notification in E2E test workflow (#14538) Add regression testing for pruning bug (#14454) Bump owner dep (#14531) Fix state view (#14532) Deployment tooling (#14533) CCIP 3388 - add offramp generation (#14526) CCIP-3416 paginate token admin registry get all tokens call (#14514) Change Polygon zkEVM to use FeeHistory estimator (#14161) [TT-1747] fix core changeset (#14524) TT-1459 Use CTF actions from .github repo (#14522) [TT-1693] try more universal Solidity scripts (#14436) Remove unused workflow for e2e tests (#14520) BCI-3668 Optimise HeadTracker's memory usage (#14130) BCFR-888 LP support chains that have not reached finality yet (#14366) support new heads polling over http rpc client (#14373) Bump CTF (#14518) TT-1550 Migrate remaining E2E workflows to the reusable workflow (#14403) ...
LogPoller aborts fetching logs and silently aborts replay if the chain’s latest finalized block is 0.
This causes CCIP Load tests to fail, as Jobs, created before finality is reached, are unable to find configs.