CCIP-2881 USDC Reader integration tests #14516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusz-sekara
requested review from
a team,
RensR,
matYang,
RayXpub and
elatoskinas
as code owners
mateusz-sekara
requested review from
patrickhuie19
and removed request for
a team
mateusz-sekara
changed the title
winder
previously approved these changes
Sep 23, 2024
RensR
reviewed
Sep 24, 2024
| @@ -44,6 +44,10 @@ compileContract () { | |||
| echo "CCIPReaderTester uses 1 optimizer runs for reduced contract size." | |||
| optimize_runs=1 | |||
| ;; | |||
| "ccip/test/helpers/USDCReaderTester.sol") | |||
| echo "USDCReaderTest uses 1 optimizer runs for reduced contract size." | |||
There was a problem hiding this comment.
Why? It would probably fit perfectly well without this custom logic?
There was a problem hiding this comment.
It was a blind copy paste from other tests, can remove
There was a problem hiding this comment.
imo the other one also doesn't need it.
There was a problem hiding this comment.
Removed this one and the previous one
RensR
reviewed
Sep 24, 2024
RensR
previously approved these changes
Sep 24, 2024
mateusz-sekara
force-pushed
the
usdc-reader-tests
branch
from
1c4306c to
8426a7e
Compare
mateusz-sekara
force-pushed
the
usdc-reader-tests
branch
from
8426a7e to
7dc9d49
Compare
RensR
approved these changes
Sep 24, 2024
asoliman92
approved these changes
Sep 24, 2024
|
momentmaker
added a commit
that referenced
this pull request
Sep 24, 2024
…develop * origin/develop: (233 commits) update Smoke Test TestAutomationBasic to load pre-deployed contracts if given (#14537) CCIP-2881 USDC Reader integration tests (#14516) [TT-1624] link PR to solidity review issue (#14521) Fix skipped notification in E2E test workflow (#14538) Add regression testing for pruning bug (#14454) Bump owner dep (#14531) Fix state view (#14532) Deployment tooling (#14533) CCIP 3388 - add offramp generation (#14526) CCIP-3416 paginate token admin registry get all tokens call (#14514) Change Polygon zkEVM to use FeeHistory estimator (#14161) [TT-1747] fix core changeset (#14524) TT-1459 Use CTF actions from .github repo (#14522) [TT-1693] try more universal Solidity scripts (#14436) Remove unused workflow for e2e tests (#14520) BCI-3668 Optimise HeadTracker's memory usage (#14130) BCFR-888 LP support chains that have not reached finality yet (#14366) support new heads polling over http rpc client (#14373) Bump CTF (#14518) TT-1550 Migrate remaining E2E workflows to the reusable workflow (#14403) ...
RensR
pushed a commit
that referenced
this pull request
Oct 1, 2024
* Test scaffold * Working test * Fixes * Fixes * Fixes * Bump * Minor fixes * [Bot] Update changeset file with jira issue * Minor fixes * Minor fixes * Minor fixes * Minor fixes * Using facade * Using facade * Post review fixes * Update gethwrappers --------- Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Resolves
Integration tests for changes in CCIP repo smartcontractkit/chainlink-ccip#147