Enable Typescript codesharing between OperatorUI & Styleguide #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rupurt
force-pushed
the
chores/operator-ui-strict-typescript
branch
from
0da7bee to
ba527a4
Compare
se3000
force-pushed
the
chores/operator-ui-strict-typescript
branch
from
b0dc7fc to
b030a63
Compare
rupurt
force-pushed
the
chores/operator-ui-strict-typescript
branch
5 times, most recently
from
edd25dc to
0f1b190
Compare
se3000
force-pushed
the
chores/operator-ui-strict-typescript
branch
3 times, most recently
from
cf3f108 to
77f7267
Compare
se3000
reviewed
Jul 28, 2019
| @@ -0,0 +1 @@ | |||
| {"version":3,"file":"SimpleList.jsx","sourceRoot":"","sources":["SimpleList.tsx"],"names":[],"mappings":"AAAA,OAAO,KAAK,MAAM,OAAO,CAAA;AACzB,OAAO,KAAK,MAAM,yBAAyB,CAAA;AAC3C,OAAO,SAAS,MAAM,6BAA6B,CAAA;AACnD,OAAO,IAAI,MAAM,wBAAwB,CAAA;AACzC,OAAO,SAAS,MAAM,SAAS,CAAA;AAO/B,MAAM,UAAU,GAAG,CAAC,EAAE,QAAQ,EAAE,KAAK,EAAU,EAAE,EAAE;IACjD,OAAO,CACL,CAAC,IAAI,CACH;MAAA,CAAC,SAAS,CAAC,CAAC,KAAK,CAAC,EAAE,SAAS,CAE7B;;MAAA,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC,EAAE,WAAW,EAAE,OAAO,EAAE,CAAC,CACrC;QAAA,CAAC,SAAS,CAAC,CAAC,QAAQ,CAAC,EAAE,SAAS,CAClC;MAAA,EAAE,KAAK,CACT;IAAA,EAAE,IAAI,CAAC,CACR,CAAA;AACH,CAAC,CAAA;AAED,eAAe,UAAU,CAAA"} | |||
There was a problem hiding this comment.
Should we be checking in .map files? This is the only opinion I could find after a quick search, and it doesn't seem very definitive. Also, I see this is in src and I'm wondering checking it in is actually necessary.
There was a problem hiding this comment.
I feel like we should commit them because it helps with editor navigation. Otherwise each dev would need to run yarn workspace @chainlink/styleguide build when they pull fresh changes.
There was a problem hiding this comment.
sorry for interjecting but hook it into a postinstall?
ill take a review look tonight
rupurt
force-pushed
the
chores/button-type-annotations
branch
from
3c5da16 to
cbe6dda
Compare
rupurt
force-pushed
the
chores/operator-ui-strict-typescript
branch
from
77f7267 to
3a09ec7
Compare
|
@se3000 @NavyAdmiral I had to update the base branch for this which dismissed the review |
rupurt
force-pushed
the
chores/operator-ui-strict-typescript
branch
from
3a09ec7 to
8a25ca6
Compare
se3000
previously approved these changes
Jul 29, 2019
NavyAdmiral
previously requested changes
Jul 30, 2019
NavyAdmiral
reviewed
Jul 30, 2019
rupurt
force-pushed
the
chores/operator-ui-strict-typescript
branch
from
59c8d6f to
a383801
Compare
se3000
previously approved these changes
Jul 30, 2019
se3000
approved these changes
Jul 31, 2019
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 10, 2024
* fix typeAndVersion (#1479) * Add seq number to CCIPMessageSent event (#1481) ## Motivation Easily retrieve `CCIPMessageSent` events in the absence of Atlas / another event indexer ## Solution Add sequenceNumber as an indexed field to `CCIPMessageSent` event * Rename IRMNV2 => IRMNRemote (#1484) ## Motivation IRMNRemote is a better name ## Solution Rename to `IRMNRemote` * contracts/ccip/capability: per (donId, pluginType) active config indexes (#1488) * fix typo (#1486) Closes #1482 * feat: add getter to return all source chain config (#1477) ## Motivation The current offchain initialization process involves calling getSourceChainConfig(sourceChainSelector), which retrieves configurations for a specific source chain selector. However, there's no mechanism to fetch a complete list of supported source chains during the initialization phase. This limitation complicates the process, as the full list of source chain selectors is not readily available. ## Solution To address this, the proposed solution introduces an enumerable set of all source chain selectors. By implementing a getAllSourceChainConfig() function, we can easily retrieve the complete list of source chains on-chain. This eliminates the need for additional rounds of OCR gossip to share known source chains, simplifying initialization and improving efficiency. --------- Signed-off-by: 0xsuryansh <suryansh.shrivastava@smartcontract.com> Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com> Co-authored-by: Rens Rooimans <github@rensrooimans.nl> * Pool to support rebasing mint call (#1490) This basic pool supports rebasing minting * Fix/onramp allowlist race condition (#1480) * gen wrappers --------- Signed-off-by: 0xsuryansh <suryansh.shrivastava@smartcontract.com> Co-authored-by: Ryan Hall <RyanRHall@users.noreply.github.com> Co-authored-by: Makram <makramkd@users.noreply.github.com> Co-authored-by: Suryansh <39276431+0xsuryansh@users.noreply.github.com> Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn workspace @chainlink/styleguide run build