Minimum payment should be controllable on the job level #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NavyAdmiral
force-pushed
the
features/add-min-payment-to-jobspec
branch
from
f155778 to
edca3ed
Compare
j16r
reviewed
Aug 6, 2019
NavyAdmiral
force-pushed
the
features/add-min-payment-to-jobspec
branch
2 times, most recently
from
edc3b4f to
eb75454
Compare
|
@j16r tried to address your concerns, could you take a look again? |
NavyAdmiral
force-pushed
the
features/add-min-payment-to-jobspec
branch
2 times, most recently
from
f6adbdc to
eab8c5e
Compare
j16r
suggested changes
Aug 8, 2019
NavyAdmiral
commented
Aug 8, 2019
NavyAdmiral
force-pushed
the
features/add-min-payment-to-jobspec
branch
from
eab8c5e to
c35f28c
Compare
|
@j16r Addressed your comments ⚓ |
|
🚢 
RensR
added a commit
that referenced
this pull request
Oct 10, 2024
This basic pool supports rebasing minting
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 10, 2024
* fix typeAndVersion (#1479) * Add seq number to CCIPMessageSent event (#1481) ## Motivation Easily retrieve `CCIPMessageSent` events in the absence of Atlas / another event indexer ## Solution Add sequenceNumber as an indexed field to `CCIPMessageSent` event * Rename IRMNV2 => IRMNRemote (#1484) ## Motivation IRMNRemote is a better name ## Solution Rename to `IRMNRemote` * contracts/ccip/capability: per (donId, pluginType) active config indexes (#1488) * fix typo (#1486) Closes #1482 * feat: add getter to return all source chain config (#1477) ## Motivation The current offchain initialization process involves calling getSourceChainConfig(sourceChainSelector), which retrieves configurations for a specific source chain selector. However, there's no mechanism to fetch a complete list of supported source chains during the initialization phase. This limitation complicates the process, as the full list of source chain selectors is not readily available. ## Solution To address this, the proposed solution introduces an enumerable set of all source chain selectors. By implementing a getAllSourceChainConfig() function, we can easily retrieve the complete list of source chains on-chain. This eliminates the need for additional rounds of OCR gossip to share known source chains, simplifying initialization and improving efficiency. --------- Signed-off-by: 0xsuryansh <suryansh.shrivastava@smartcontract.com> Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com> Co-authored-by: Rens Rooimans <github@rensrooimans.nl> * Pool to support rebasing mint call (#1490) This basic pool supports rebasing minting * Fix/onramp allowlist race condition (#1480) * gen wrappers --------- Signed-off-by: 0xsuryansh <suryansh.shrivastava@smartcontract.com> Co-authored-by: Ryan Hall <RyanRHall@users.noreply.github.com> Co-authored-by: Makram <makramkd@users.noreply.github.com> Co-authored-by: Suryansh <39276431+0xsuryansh@users.noreply.github.com> Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com>
mateusz-sekara
pushed a commit
that referenced
this pull request
Jan 10, 2025
This basic pool supports rebasing minting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #164214281