Solana offchain plugin #15974
Draft
Solana offchain plugin #15974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add solana support to contract transmitter * add changeset * one more place * address unsupported chain family * encode offramp addr * fix breaking change * rename * test * revert
…r-config-to-plugin-creator
* no-op for solana estimate providers * add changeset * token data noop * noop for solana rmn * fix lint
…reader-config-to-plugin-creator Add Solana chain reader config to plugin creator
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
makramkd
reviewed
Jan 23, 2025
Comment on lines
229
to
230
| if checkSum { | ||
| offRampAddr = common.BytesToAddress(addr).Hex() |
There was a problem hiding this comment.
Think you can just make this the default
Comment on lines
513
to
516
| if chainID == homeChainID { | ||
| lggr.Debugw("Adding home chain reader config", "chainID", chainID) | ||
| cfg = solanaconfig.MergeReaderConfigs(cfg, solanaconfig.HomeChainReaderConfigRaw) | ||
| } |
There was a problem hiding this comment.
Don't think this is needed, Solana will never be home chain
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.