-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[CRE-1492] allow tests to run EVM cap tests on two chains #20581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…code left from refactor
|
I see you updated files related to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enables EVM capability tests to run on two chains by removing single-chain constraints that were previously in place. The changes involve cleaning up commented code from a previous refactor, updating OCR3 contract deployment to use per-chain selectors instead of the registry chain selector, and enabling EVM capabilities on both chains (1337 and 2337) in the topology configurations.
Key Changes:
- Removed TODO comments and code that artificially limited tests to a single blockchain
- Modified OCR3 contract deployment to deploy contracts on each EVM chain instead of only on the registry chain
- Updated TOML configurations to enable EVM capability on both chains 1337 and 2337
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| system-tests/tests/smoke/cre/cre_suite_test.go | Removed single-chain limitations and TODO comments; added t.Skip() to multiple v2 test cases |
| system-tests/tests/regression/cre/cre_regression_suite_test.go | Removed single-chain blockchain filtering and associated TODO comments |
| system-tests/lib/cre/features/evm/v2/evm.go | Updated OCR3 deployment to use chain-specific selectors; removed large block of commented code; fixed typos |
| core/scripts/cre/environment/examples/workflows/v2/proof-of-reserve/cron-based/main.go | Changed hardcoded chain selector to use config value |
| core/scripts/cre/environment/examples/workflows/v2/proof-of-reserve/cron-based/go.mod | Removed unused chain-selectors dependency |
| core/scripts/cre/environment/configs/workflow-gateway-don.toml | Enabled EVM capability for both chains 1337 and 2337 |
| core/scripts/cre/environment/configs/workflow-gateway-capabilities-don.toml | Added chain configuration comments and enabled EVM on appropriate chains |
| core/scripts/cre/environment/configs/workflow-don.toml | Enabled EVM capability for both chains 1337 and 2337 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
core/scripts/cre/environment/configs/workflow-gateway-capabilities-don.toml
Outdated
Show resolved
Hide resolved
|
* allow tests to run EVM cap tests on two chains, remove commented out code left from refactor * typos + removal of t.Skip()
* [CRE-1492] allow tests to run EVM cap tests on two chains (#20581) * allow tests to run EVM cap tests on two chains, remove commented out code left from refactor * typos + removal of t.Skip() * better messages


and... remove commented out code left from refactor
and... deploy OCR3 contracts for EVM on each chain instead of the registry chain