[PRODCRE-1492] optional billing & beholder setup#20594
Merged
Conversation
* allow tests to run EVM cap tests on two chains, remove commented out code left from refactor * typos + removal of t.Skip()
…nal-billing-beholder-setup
Contributor
|
I see you updated files related to
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the Chip Ingress and Billing Service setup optional for users who don't have access to the necessary repositories or ECRs. The changes allow the setup process to skip these components when their configurations are not provided.
- Made
ChipIngressandBillingServiceconfiguration fields optional by converting them to pointers - Added conditional logic to skip Chip Ingress setup when configuration is absent
- Enhanced validation to ensure billing configuration is present when the
withBillingflag is used
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
chudilka1
approved these changes
Dec 11, 2025
Tofel
changed the title
george-dorin
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Some of the users do not need Chip Ingress/Billing, they don't have access to repos/ECRs and they want to be able to skip that part of the setup.