Truncate long errors keeping head and diagnostic tail#263
Open
nadahalli wants to merge 2 commits intoadd-workflow-logs-commandfrom
Open
Truncate long errors keeping head and diagnostic tail#263nadahalli wants to merge 2 commits intoadd-workflow-logs-commandfrom
nadahalli wants to merge 2 commits intoadd-workflow-logs-commandfrom
Conversation
Drop the first 40% of long error messages (>80 chars) since the useful diagnostic info (e.g. PCR mismatches) sits at the end, after layers of generic wrapping.
For errors >120 chars, show the beginning + "..." + last 40%. Nested error wrapping puts the useful diagnostic (e.g. PCR mismatches) at the end; this keeps both ends visible.
timothyF95
previously approved these changes
Feb 12, 2026
| if ev.Status == "failure" && len(ev.Errors) > 0 { | ||
| errMsg := ev.Errors[0].Error | ||
| if len(errMsg) > 120 { | ||
| errMsg = errMsg[:120] + "..." |
Collaborator
There was a problem hiding this comment.
I mean I kind of think both the solutions are inadequate.
Earlier, we only showed first 120 chars.
Now, either we show beginning and end parts, or if too long, we should only the ending error.
Maybe would be better if cli folks can instead save it to a tmp error file and point to it.
Otherwise, I think just showing the 1st 120 chars was decent enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
...+ last 40%Before
After
Stacked on #262.