Skip to content

Truncate long errors keeping head and diagnostic tail #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nadahalli wants to merge 2 commits into
base: add-workflow-logs-command
Choose a base branch
from
Open

Truncate long errors keeping head and diagnostic tail #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03caf18
Truncate long errors keeping the diagnostic tail
nadahalli Feb 12, 2026
c671cc6
Truncate long errors keeping head and diagnostic tail
nadahalli Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cmd/workflow/logs/logs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,12 @@ func (h *handler) printErrors(ctx context.Context, client *graphqlclient.Client,
if ev.Status == "failure" && len(ev.Errors) > 0 {
errMsg := ev.Errors[0].Error
if len(errMsg) > 120 {
errMsg = errMsg[:120] + "..."
Copy link
Collaborator

@prashantkumar1982 prashantkumar1982 Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean I kind of think both the solutions are inadequate.
Earlier, we only showed first 120 chars.
Now, either we show beginning and end parts, or if too long, we should only the ending error.

Maybe would be better if cli folks can instead save it to a tmp error file and point to it.
Otherwise, I think just showing the 1st 120 chars was decent enough.

tail := errMsg[len(errMsg)-len(errMsg)*2/5:] // last 40%
head := 120 - len(tail) - 3
if head < 0 {
head = 0
}
errMsg = errMsg[:head] + "..." + tail
}
fmt.Printf(" -> %s: %s\n", ev.CapabilityID, errMsg)
}
Expand Down
38 changes: 38 additions & 0 deletions cmd/workflow/logs/logs_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,44 @@ func TestExecute(t *testing.T) {
assert.Greater(t, failureIdx, successIdx, "oldest execution should appear first")
})

t.Run("long error is truncated keeping tail", func(t *testing.T) {
longErr := "failed to execute enclave request. enclave ID: abc123, error: attestation validation failed for ExecuteBatch: expected PCR0 deadbeef, got cafebabe"
ts := newMockGraphQL(t, mockConfig{
workflows: []map[string]any{
{"uuid": "wf-1", "name": "test-workflow", "status": "ACTIVE"},
},
executions: []map[string]any{
{
"uuid": "exec-1",
"status": "FAILURE",
"startedAt": "2026-02-12T16:00:00Z",
"finishedAt": "2026-02-12T16:00:01Z",
},
},
events: []map[string]any{
{
"capabilityID": "confidential-http@1.0.0",
"status": "failure",
"errors": []map[string]any{{"error": longErr, "count": 1}},
},
},
})
defer ts.Close()

output := captureStdout(t, func() {
h := newTestHandler(ts.URL, "test-workflow", false, 10)
err := h.Execute(context.Background())
require.NoError(t, err)
})

// Head (beginning) should be present
assert.Contains(t, output, "failed to execute enclave")
// Tail (last 40%) should survive truncation
assert.Contains(t, output, "expected PCR0 deadbeef, got cafebabe")
// Middle should be elided
assert.Contains(t, output, "...")
})

t.Run("workflow not found", func(t *testing.T) {
ts := newMockGraphQL(t, mockConfig{})
defer ts.Close()
Expand Down