Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base Widget Support #202

Merged
merged 4 commits into from
Oct 10, 2019
Merged

Base Widget Support #202

merged 4 commits into from
Oct 10, 2019

Conversation

Jack-Byrne
Copy link
Collaborator

This PR adds changes required to RPCs that were introduced by the widgets proposal.

This pr does not add widget functionality to the generic HMI, these are only minimal changes required for the HMI to work with Core 6.0.0.

Updates:

  • Deprecate SetDisplayLayout
  • Update show request to handle template configurations
  • Add text supported to soft button capabilities
  • Update Capabilities structure
  • Add OnSystemCapabilityUpdated notification to core

@iCollin
Copy link
Collaborator

iCollin commented Oct 9, 2019

I have a question about the getWindowCapability(template) function:

It's main client is BCController.js when handling the OnAppRegistered RPC, where it seems to be called with either MEDIA or NON-MEDIA template based on rpc.params.application.isMediaApplication.

Neither of these templates in DisplayCapabilities.js have softButtonCapabilities or buttonCapabilities within the displayCapabilities object.

Therefore, won't the return of this function always have a null buttonCapabilities and softButtonCapabilities?

@Jack-Byrne
Copy link
Collaborator Author

@iCollin Good catch. My mistake here was thinking softbutton capabilities was included in the displayCapabilities json object.

src/js/Controllers/DisplayCapabilities.js Outdated Show resolved Hide resolved
src/js/Controllers/UIController.js Outdated Show resolved Hide resolved
@Jack-Byrne Jack-Byrne merged commit 9c819d3 into develop Oct 10, 2019
@Jack-Byrne Jack-Byrne mentioned this pull request Oct 29, 2019
@jacobkeeler jacobkeeler deleted the feature/base_widgets_rpc_support branch July 9, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants