Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/tile menu name overflow #203

Merged
merged 5 commits into from
Oct 16, 2019
Merged

Fix/tile menu name overflow #203

merged 5 commits into from
Oct 16, 2019

Conversation

iCollin
Copy link
Collaborator

@iCollin iCollin commented Oct 9, 2019 •
edited
Loading

This PR is depends on changes made in #202

This PR fixes issue #196

This PR adds a css property to hscrollmenu-item__name that will prevent extremely long option names from overflowing.

Updates:

  • Add overflow: scroll; property to hscrollmenu-item__name
  • Add a null check to app before attempting to grab app.menuLayout in InAppMenu.js render()

@iCollin iCollin mentioned this pull request Oct 10, 2019
Closed
@iCollin
revert svg changes
0d96624 
all svg classes .st0 will be updated to a new format later
@iCollin
Merge branch 'develop' into fix/tile_menu_name_overflow
1acf8cc
@iCollin iCollin merged commit c44eeab into develop Oct 16, 2019
@jacobkeeler jacobkeeler deleted the fix/tile_menu_name_overflow branch July 9, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobkeeler jacobkeeler jacobkeeler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iCollin @jacobkeeler