Add script to check #1306 issue #1931
Conversation
| end) | ||
|
|
||
| TtsParams.appID = common.getHMIAppId() | ||
| EXPECT_HMICALL("TTS.SetGlobalProperties", TtsParams) |
There was a problem hiding this comment.
TtsParams is empty, must be params.TtsParams.
| self.hmiConnection:SendResponse(data.id, data.method, "SUCCESS", {}) | ||
| end) | ||
|
|
||
| TtsParams.appID = common.getHMIAppId() |
| self.hmiConnection:SendResponse(data.id, data.method, "SUCCESS", {}) | ||
| end) | ||
|
|
||
| TtsParams.appID = common.getHMIAppId() |
There was a problem hiding this comment.
TtsParams -> params.TtsParams
| end | ||
|
|
||
| local function ResetGlobalPropertiesSUCCES(params, self) | ||
| local cid = self.mobileSession1:SendRPC("SetGlobalProperties", params.requestParams) |
There was a problem hiding this comment.
Request from mobile must be ResetGlobalProperties,
also pay attention that params for ResetGlobalProperties are not the same as for SetGlobalProperties,
| local cid = self.mobileSession1:SendRPC("SetGlobalProperties", params.requestParams) | ||
|
|
||
| params.UiParams.appID = common.getHMIAppId() | ||
| EXPECT_HMICALL("UI.SetGlobalProperties", params.UiParams) |
There was a problem hiding this comment.
must be expected default values from .ini file
| end) | ||
|
|
||
| TtsParams.appID = common.getHMIAppId() | ||
| EXPECT_HMICALL("TTS.SetGlobalProperties", TtsParams) |
There was a problem hiding this comment.
must be expected default values from .ini file
|
Expected behavior is under clarification in smartdevicelink/sdl_requirements#98 |
HSavynetska
force-pushed
the
Defect_1306
branch
from
e9ed085
to
ba7c6eb
Compare
| -- 1) SDL should send to HMI UI.SetGlobalProperties("vrHelpTitle", "vrHelp") with default values. | ||
| -- 2) SDL should send to HMI TTS.SetGlobalProperties with "helpPrompt" parameter that should be reset to default value | ||
| -- (smartDeviceLink.ini file contains default values for "helpPrompt" | ||
| -- Actual result: |
There was a problem hiding this comment.
remove actual result
|
|
||
| local requesUIparams = { | ||
| vrHelpTitle = getValueFromIniFile(pathToIniFile, "HelpTitle"), | ||
| vrHelp = {{ position = 1, text = actions.getConfigAppParams(pAppId).appName }} |
There was a problem hiding this comment.
pAppId is empty, please remove
| } | ||
|
|
||
| --[[ Local Functions ]] | ||
| local function getValueFromIniFile(path_to_ini, parameter_name) |
There was a problem hiding this comment.
Please remove this local function, can be used commonFunctions:read_parameter_from_smart_device_link_ini function instead of local one.
| helpPrompt = requestParams.helpPrompt | ||
| } | ||
|
|
||
| local allParams = { |
There was a problem hiding this comment.
The better usage:
local allParams = {
requestParams = requestParams,
UiParams = {
vrHelpTitle = requestParams.vrHelpTitle,
vrHelp = requestParams.vrHelp,
},
TtsParams = {
timeoutPrompt = requestParams.timeoutPrompt,
helpPrompt = requestParams.helpPrompt
}
}
| local paramTP = getValueFromIniFile(pathToIniFile, "TimeOutPromt") | ||
|
|
||
| local requesTTSparams = { | ||
| helpPrompt = {{ text = paramHP[1], type = "TEXT"}, {text = paramHP[2], type = "TEXT"}}, |
There was a problem hiding this comment.
paramHP and paramTP can contain not 2 elements, need to get the array and set values for helpPrompt elements in loop.
|
Current develop(a7db5cc) branch is merged into PR. |
dboltovskyi
force-pushed
the
Defect_1306
branch
from
4602853
to
e2378ac
Compare
dboltovskyi
changed the title
ATF Test Scripts to check #1306
This PR is [ready] for review.
Summary
Add test scripts to check the 1306 issue.
ATF version
develop
Changelog
7.0issuesCLA