Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDL 0255] Feature/Enhance BodyInformation vehicle data #2489

Merged

Conversation

dboltovskyi
Copy link
Contributor

@dboltovskyi dboltovskyi commented Nov 26, 2020

ATF Test Scripts to check #3133

This PR is [ready] for review.

Summary

Updates for Vehicle Data scripts related to "[SDL 0255] Enhance BodyInformation vehicle data" feature

ATF version

7.1.0_version_bump

Changelog

  • updated common module for RGNSD tests with new parameters

CLA

@KhrystynaDubovyk
Copy link

@atiwari9 please review this PR

@atiwari9
Copy link

atiwari9 commented Dec 2, 2020

@dboltovskyi - Can you please rebase with feature/extended_vd_coverage

@dboltovskyi
Copy link
Contributor Author

@atiwari9 Please find update in 3e2f589

@atiwari9
Copy link

atiwari9 commented Dec 3, 2020

@dboltovskyi - Some tests failed for bodyInformation, please see the logs:
BodyInfo_3Failed.zip

@dboltovskyi
Copy link
Contributor Author

@atiwari9 It looks like environment issue.
All fails are related to Start_SDL__HMI__connect_Mobile__start_Session step and have Error: Socket not opened error message.

Could you do the following please:

  1. Check there is no Web-HMI opened (e.g. in some browser tab). If so some of the messages from SDL could be processed not by ATF, but Web-HMI since the connection port is the same.
  2. Restart these tests one more time.

@atiwari9
Copy link

atiwari9 commented Dec 7, 2020

Another run was successful :
BodyInfo_AllPass.zip

Copy link

@atiwari9 atiwari9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@LitvinenkoIra
Copy link
Contributor

@JackLivio This PR is ready for Livio review. Thank you!

@iCollin
Copy link
Collaborator

iCollin commented Jan 19, 2021

Hello, would it be difficult to rebase this PR on develop? If it is not much effort, I would like to merge this PR before feature/extended_vd_coverage. Thank you!

@dboltovskyi dboltovskyi changed the base branch from feature/extended_vd_coverage to develop January 19, 2021 16:48
@dboltovskyi dboltovskyi changed the base branch from develop to feature/extended_vd_coverage January 19, 2021 16:52
@dboltovskyi dboltovskyi force-pushed the feature/sdl_0255_enhance_bodyInformation_vehicle_data branch from 5f79f42 to 70556df Compare January 19, 2021 16:54
@dboltovskyi dboltovskyi changed the base branch from feature/extended_vd_coverage to develop January 19, 2021 16:54
@dboltovskyi
Copy link
Contributor Author

@iCollin Please notice this PR has been re-based onto latest develop. However it couldn't be done without force-push.

@iCollin iCollin merged commit 915f889 into develop Jan 25, 2021
@iCollin iCollin deleted the feature/sdl_0255_enhance_bodyInformation_vehicle_data branch January 25, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants