fix compiler error on ubuntu 12.04 x86_64 and remove duplicated items for smartDeviceLink.ini #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -42,7 +42,8 @@ | |||
| #include <sys/sysctl.h> | |||
| #include <sys/socket.h> | |||
| #ifdef __linux__ | |||
| # include <linux/tcp.h> | |||
| //# include <linux/tcp.h> | |||
There was a problem hiding this comment.
Is there a reason to commit commented code into the repository?
There was a problem hiding this comment.
commented code has been removed.
|
@chenbd I'm going to be merging in a (hopefully) final internal release today or tomorrow before we move completely to pull requests. Just a heads up because it might require a rebase. This change lgtm though |
|
@justinjdickow my branch has been rebased. seems we still have a lot work to do. |
error message like this: /usr/include/linux/tcp.h:72: error: ‘__u32 __fswab32(__u32)’ cannot appear in a constant-expression
PKramchaninov
pushed a commit
that referenced
this pull request
Apr 10, 2015
fix compiler error on ubuntu 12.04 x86_64 and remove duplicated items for smartDeviceLink.ini
anosach-luxoft
added a commit
that referenced
this pull request
May 19, 2016
Make google test buildable on Windows
dev-gh
pushed a commit
to dev-gh/sdl_core
that referenced
this pull request
Jun 7, 2016
…st-build Make google test buildable on Windows Related-issues: APPLINK-22713, APPLINK-22716
LuxoftAKutsan
pushed a commit
that referenced
this pull request
Feb 23, 2017
…nsent-passangers REVSDL-1048: Fix name of user consent for passangers` devices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.