Hotfix/ATF_AddSubMenu known issues resolve

[BrandonHe]

Please review @pestOO @AGaliuzov @anosach-luxoft

Update:

• RequestController::UpdateTimer():
  
  Change the timer update logic from waiting until close and restart to unblock the waiting threads, avoid timeout issue
• RequestController::OnTimer():
  
  Add Autolock and wait to process the condition of NOT probably_expired
• Set clean up data to NULL after it's deleted

Test:

• Both ATF_AddSubMenu and ATF_SetMediaClockTimer ATF tests are passed, do the test several times

• SPT AddSubMenu test passed(successfully add ten submenu)

• make test passed result:

  Start 1: test_JSONCPP
  1/21 Test How to handle bad/corrupt data  #1: test_JSONCPP ..................... Passed 0.04 sec
  Start 2: transport_manager_test
  2/21 Test BlueZ 5.x transport adapter #2: transport_manager_test ........... Passed 0.32 sec
  Start 3: resumption_test
  3/21 Test Custom Lock Screen Icon Defined by the OEM #3: resumption_test .................. Passed 0.02 sec
  Start 4: formatters_test
  4/21 Test Contributing guidelines file is missing #4: formatters_test .................. Passed 0.22 sec
  Start 5: protocol_handler_test
  5/21 Test Whitespace fields in show command being rejected #5: protocol_handler_test ............ Passed 42.93 sec
  Start 6: connection_handler_test
  6/21 Test Current CMakelists.txt does not support cross-compiling to Embedded Linux #6: connection_handler_test .......... Passed 83.30 sec
  Start 7: utils_test
  7/21 Test Remote App Launch #7: utils_test ....................... Passed 20.61 sec
  Start 8: generator_test
  8/21 Test Loss of communication on Ubuntu 14.04.1 #8: generator_test ................... Passed 0.02 sec
  Start 9: security_manager_test
  9/21 Test Add SDL version info in BasicCommunication.GetSystemInfo Response #9: security_manager_test ............ Passed 1.00 sec
  Start 10: policy_test
  10/21 Test GENIVI git repos out of sync #10: policy_test ...................... Passed 7.29 sec
  Start 11: rpc_base_test
  11/21 Test Add a default response for startH264 #11: rpc_base_test .................... Passed 0.03 sec
  Start 12: smart_object_test
  12/21 Test OnHMIStatus notification should contain the 'trigger source' #12: smart_object_test ................ Passed 0.73 sec
  Start 13: application_manager_test
  13/21 Test SDL should notify the applications if the head unit switches between day and night mode #13: application_manager_test ......... Passed 1.89 sec
  Start 14: data_resumption_test
  14/21 Test -DENABLE_LOG=OFF #14: data_resumption_test ............. Passed 0.03 sec
  Start 15: state_controller_test
  15/21 Test bluez dependency checking #15: state_controller_test ............ Passed 0.39 sec
  Start 16: commands_test
  16/21 Test [Spec] StartServiceACK control frame is not backward compatible #16: commands_test .................... Passed 0.11 sec
  Start 17: mobile_commands_test
  17/21 Test [Spec] The version can never be increased beyond 15, or backward compatibility is broken #17: mobile_commands_test ............. Passed 0.08 sec
  Start 18: message_helper_test
  18/21 Test fix compiler error on ubuntu 12.04 x86_64 and remove duplicated items for smartDeviceLink.ini #18: message_helper_test .............. Passed 0.10 sec
  Start 19: hmi_message_handler_test
  19/21 Test Building/running occasionally modifies src/3rd_party/apr-1.5.0/include/apr.h in the source tree #19: hmi_message_handler_test ......... Passed 0.02 sec
  Start 20: config_profile_test
  20/21 Test Added contributing file, fixes #4 #20: config_profile_test .............. Passed 0.41 sec
  Start 21: media_manager_test
  21/21 Test cmake update #21: media_manager_test ............... Passed 0.04 sec

100% tests passed, 0 tests failed out of 21

Total Test time (real) = 159.64 sec

[AByzhynar]

@BrandonHe

1. These tests aren't ATF , but just unit tests. ATF & unit tests are different things. Don't mix them.
2. Branch has wrong name. hotfix must be sent to master branch ONLY. Only fix or feature can be sent to develop branch.

[BrandonHe]

@AByzhynar Thanks!

1. Yes, these tests aren't ATF, I wasn't attach the ATF test result, it has too much content I think. I tested under sdl_atf with test scripts ATF_AddSubMenu and ATF_SetMediaClockTimer in sdl_atf_test_scripts,
2. OK, I will rename the branch to fix and resend PR.

[BrandonHe]

close this PR as resend new PR #660