Feature/interior vehicle data resumption #2674
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
1 task
mked-luxoft
force-pushed
the
feature/interior_vehicle_data_resumption
branch
from
9ac5865
to
b787f38
Compare
|
@mked-luxoft Please rebase to the latest develop branch. |
mked-luxoft
force-pushed
the
feature/interior_vehicle_data_resumption
branch
from
b787f38
to
2b34a55
Compare
Added Restore/Revert data functionality Added Pending resumption handling
Implemented callback for cases if app resumes successfully without sending HMI requests
Added container to store successful ivd subscriptions for correct revert failed resumption
mked-luxoft
force-pushed
the
feature/interior_vehicle_data_resumption
branch
from
2b34a55
to
01cefc6
Compare
LitvinenkoIra
changed the base branch from
develop
to
feature/resumption_data_error_handling
|
Not actual |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ NOTE ❗ : This implementation is based on Handle response from HMI during resumption data, so this PR should be merged AFTER #2619
Fixes #2661
This PR is [ready] for review.
Risk
This PR makes [no] API changes.
Testing Plan
ATF tests provided feature/interior_vehicle_data_resumption
HMI Implementation
HMI Implementation provided in smartdevicelink/sdl_hmi#139
Summary
This feature is based on feature/resumption data error handling. Apart from changes concerning handling errors from hmi during resumption, this feature introduces following changes:
handling resumption of interior vehicle data subscriptions
handling pending subscriptions to interior vehicle data during resumption
added UpdateHash() call on each internal subscription to interior vehicle data
response with code WARNINGS is sent if application repeatedly tries to subscribe to the same interior vehicle data module
Tasks Remaining:
CLA