Feature/button subscription response from hmi #2740
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mked-luxoft
requested review from
jacobkeeler,
Jack-Byrne and
yang1070
and removed request for
jacobkeeler,
Jack-Byrne and
yang1070
|
@mked-luxoft please resolve conflicts and re-base branch - create good git history. |
2 tasks
mked-luxoft
force-pushed
the
feature/button_subscription_response_from_hmi
branch
from
e06e21a
to
3421252
Compare
…ptionNotification
During Data resumption Application is not yet registered.
Changed HandleOnTimeout interface
Added Restore/Revert data functionality Added Pending resumption handling
Implemented callback for cases if app resumes successfully without sending HMI requests
Added container to store successful ivd subscriptions for correct revert failed resumption
mked-luxoft
force-pushed
the
feature/button_subscription_response_from_hmi
branch
from
3421252
to
be3846d
Compare
|
Closed in favor of #3743 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ NOTE ❗ : This implementation is based on Handle response from HMI during resumption data and Interior Vehicle Data resumption, so this PR should be merged AFTER #2619 and #2674
Fixes #2508
This PR is [ready] for review.
Risk
This PR makes [major] API changes.
Testing Plan
ATF tests are provided
Summary
In this PR OnButtonSubscription notification is replaced with
(Un)SubscribeButton request/response.
Changelog
API was updated, as well as new request/response classes were introduces in SDL core.
Pending subscription resolution mechanism was introduced in case HMI responds to request after default timeout.
Moreover, ButtonNotificationToMobile class was created to encapsulate duplicated logic of OnButtonPress and OnButtonEvent
Bug Fixes
#967 is fixed in scope of this feature
CLA