Add Parameter Media Service Data mediaImage #2927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobkeeler
reviewed
Jun 5, 2019
| @@ -1,7 +1,7 @@ | |||
| <?xml version="1.0" standalone="no"?> | |||
| <?xml-stylesheet type="text/xml" href="protocol2html.xsl"?> | |||
|
|
|||
| <interface name="SmartDeviceLink RAPI" version="5.1.0" minVersion="1.0" date="2019-03-19"> | |||
| <interface name="SmartDeviceLink RAPI" version="5.2.0" minVersion="1.0" date="2019-5-22"> | |||
There was a problem hiding this comment.
Seems that changing the date is a bit unnecessary, better just to update it after the spec is finalized.
jacobkeeler
approved these changes
Jun 7, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2897
This PR is ready for review.
Risk
This PR makes [no / minor / major] API changes.
Testing Plan
Publish media app service and send mediaImage parameter in OnAppServiceData.
Summary
Changes are small and only required the parameters to be added to the mobile and hmi api. HMI app consumers will now be able to receive the mediaImage parameter.
CLA