Start the new PTU after a failed retry sequence #3208

ydementieiev · 2020-01-13T07:38:14Z

This PR is [ready] for review.

Risk

This PR makes [no] API changes.

Summary

SDL should start the new PTU after a failed retry sequence in case some trigger occurs during the retry sequence.
Provided changes allow to perform the following actions:

Finish failed update with SDL.OnStatusUpdate(UPDATE_NEEDED);
Send SDL.OnStatusUpdate(UPDATE_NEEDED) and request PTU for applications which were added during the previous update;
Skip PTU for application which was registered during application list update timer;
Skip PTU for application with the same policy_id;

CLA

I have signed the CLA

AKalinich-Luxoft · 2020-01-13T18:22:08Z

@ydementieiev please sign CLA

AKalinich-Luxoft · 2020-01-13T18:24:13Z

src/components/application_manager/include/application_manager/application_manager_impl.h

@@ -1586,6 +1586,8 @@ class ApplicationManagerImpl

  uint32_t apps_size_;

+  bool is_registered_in_timeout_;


@ydementieiev suggest to use atomic bool as timer might be in a data race with another thread

@AKalinich-Luxoft done in fe7b393

AKalinich-Luxoft · 2020-01-13T18:24:47Z

src/components/application_manager/include/application_manager/policies/policy_handler.h

-#ifndef EXTERNAL_PROPRIETARY_MODE
-  void OnPTUTimeOut() OVERRIDE;
-#endif
+  void OnPTUTimeOut();


@ydementieiev OVERRIDE?

@AKalinich-Luxoft EXTERNAL_PROPRIETARY_MODE build failed with OVERRIDE

@ydementieiev then add pure virtual OnPTUTimeOut into interface class for EXTERNAL_PROPRIETARY_MODE

AKalinich-Luxoft · 2020-01-13T18:27:00Z

src/components/application_manager/include/application_manager/policies/policy_handler.h

+  /**
+   * @brief Application queue ready for PTU
+   */
+  std::vector<uint32_t> queue_applications_for_ptu_;


@ydementieiev i think queue will be better container for your purposes

@ydementieiev or even set as you want to keep only unique app id in your container

@ydementieiev i think this container might need access synchronization

@AKalinich-Luxoft used set and add AutoLock for work with this container in fe7b393

AKalinich-Luxoft · 2020-01-13T18:27:48Z

src/components/application_manager/include/application_manager/policies/policy_handler.h

+   * with the same app_id
+   * @param new_app_id app id new application
+   */
+  void AddNewApplicationIdToPTUQueue(const uint32_t new_app_id);


@ydementieiev can be renamed to PushAppIdToQueue and PopAppIdFromQueue

@AKalinich-Luxoft done in fe7b393

AKalinich-Luxoft · 2020-01-13T18:42:16Z

src/components/application_manager/src/policies/policy_handler.cc

@@ -2205,6 +2233,15 @@ void PolicyHandler::OnAppsSearchCompleted(const bool trigger_ptu) {
  policy_manager_->OnAppsSearchCompleted(trigger_ptu);
 }

+void PolicyHandler::OnAddedNewApplicationToAppList(
+    const uint32_t new_app_id, const std::string policy_id) {


@ydementieiev nice to have auto trace here

@AKalinich-Luxoft done in fe7b393

AKalinich-Luxoft · 2020-01-13T18:43:10Z

src/components/include/policy/policy_regular/policy/policy_manager.h

@@ -524,6 +524,12 @@ class PolicyManager : public usage_statistics::StatisticsManager,
   */
  virtual void OnAppsSearchCompleted(const bool trigger_ptu) = 0;

+  /**
+   * @brief Change applicatios count ready for PTU


@ydementieiev typo

@AKalinich-Luxoft done in fe7b393

AKalinich-Luxoft · 2020-01-13T18:43:28Z

src/components/policy/policy_external/include/policy/policy_manager_impl.h

@@ -608,6 +608,12 @@ class PolicyManagerImpl : public PolicyManager {
   */
  void OnAppsSearchCompleted(const bool trigger_ptu) OVERRIDE;

+  /**
+   * @brief Change applicatios count ready for PTU


@ydementieiev typo

@AKalinich-Luxoft done in fe7b393

AKalinich-Luxoft · 2020-01-13T18:44:59Z

src/components/policy/policy_external/include/policy/policy_manager_impl.h

@@ -1096,6 +1102,11 @@ class PolicyManagerImpl : public PolicyManager {
  bool IsPTValid(std::shared_ptr<policy_table::Table> policy_table,
                 policy_table::PolicyTableType type) const;

+  /**
+   * @brief Check that application for PTU more than zero


@ydementieiev

Suggested change

* @brief Check that application for PTU more than zero

* @brief Check that new applications for PTU were registered

@AKalinich-Luxoft done in fe7b393

AKalinich-Luxoft · 2020-01-13T18:45:35Z

src/components/policy/policy_external/include/policy/policy_manager_impl.h

+  /**
+   * @brief Count application ready for PTU
+   */
+  uint32_t count_application_;


@ydementieiev

Suggested change

uint32_t count_application_;

uint32_t applications_count_;

@ydementieiev @AKalinich-Luxoft i think name applications_pending_ptu_count_ would be more descriptive. Also, the doxygen description should be fixed accordingly

@mked-luxoft renamed fe7b393

AKalinich-Luxoft · 2020-01-13T18:49:53Z

src/components/policy/policy_external/src/update_status_manager.cc

@@ -86,6 +86,11 @@ void UpdateStatusManager::OnUpdateSentOut(uint32_t update_timeout) {
  ProcessEvent(kOnUpdateSentOut);
 }

+void UpdateStatusManager::OnUpdatePostponed() {
+  LOG4CXX_AUTO_TRACE(logger_);
+  ProcessEvent(kPostponedUpdate);


@ydementieiev consider using of SetPostponedStatus - maybe you can use it instead of kPostponedUpdate

@AKalinich-Luxoft I tried using SetPostponedStatus but always find a new regression after. Now I renamed OnUpdatePostponed to name which more describe what this method do, look please

mked-luxoft · 2020-01-14T09:43:02Z

src/components/application_manager/include/application_manager/policies/policy_handler.h

+   * @param policy_id policy_id for this application
+   */
+  void OnAddedNewApplicationToAppList(const uint32_t new_app_id,
+                                      const std::string policy_id) OVERRIDE;


this can be reference

@mked-luxoft done fe7b393

mked-luxoft · 2020-01-14T09:45:55Z

src/components/include/application_manager/policies/policy_handler_interface.h

@@ -410,6 +410,14 @@ class PolicyHandlerInterface : public VehicleDataItemProvider {
   */
  virtual void OnAppsSearchCompleted(const bool trigger_ptu) = 0;

+  /**
+   * @brief Notify that new applocation was added to application list


applocation typo

@mked-luxoft done fe7b393

mked-luxoft · 2020-01-14T09:55:53Z

src/components/policy/policy_external/include/policy/policy_manager_impl.h

+  /**
+   * @brief Count application ready for PTU
+   */
+  uint32_t count_application_;


@ydementieiev @AKalinich-Luxoft i think name applications_pending_ptu_count_ would be more descriptive. Also, the doxygen description should be fixed accordingly

mked-luxoft · 2020-01-14T10:01:23Z

src/components/policy/policy_external/src/policy_manager_impl.cc

@@ -550,6 +555,10 @@ void PolicyManagerImpl::OnPTUFinished(const PtProcessingResult ptu_result) {

  update_status_manager_.OnValidUpdateReceived();

+  if (HasApplicationForPTU()) {


is this condition independent from ptu_result?

@mked-luxoft No, no matter what the ptu_result will be from last update, we need set status to UPDATE_NEEDE for next ptu

mked-luxoft · 2020-01-14T10:05:38Z

src/components/policy/policy_regular/include/policy/policy_manager_impl.h

+  /**
+   * @brief Check that application for PTU more than zero
+   */
+  bool HasApplicationForPTU();


i think this method can be const

@mked-luxoft done fe7b393

mked-luxoft · 2020-01-14T10:07:02Z

src/components/policy/policy_regular/src/policy_manager_impl.cc

-    , trigger_ptu_(false) {}
+    , trigger_ptu_(false)
+    , ptu_requested_(false)
+    , last_registered_app_id_("") {}


is it policy_app_id? if so, then i think that the variable's name should be changed accordingly

@mked-luxoft done fe7b393

mked-luxoft · 2020-01-14T10:08:38Z

src/components/policy/policy_regular/src/update_status_manager.cc

@@ -116,6 +118,10 @@ void UpdateStatusManager::OnNewApplicationAdded(const DeviceConsent consent) {
    return;
  }
  app_registered_from_non_consented_device_ = false;
+  if (last_update_was_failed_) {
+    last_update_was_failed_ = false;
+    ProcessEvent(kPostponedUpdate);


are you sure that we still need to call ProcessEvent(kOnNewAppRegistered); if we enter this condition?

@mked-luxoft ProcessEvent(kPostponedUpdate) added for extra call UPDATE_NEEDED for new ptu if last was finished with the same status. I tried remove ProcessEvent(kOnNewAppRegistered) but it entailed a lot of regressions

mked-luxoft · 2020-01-14T10:11:14Z

src/components/application_manager/include/application_manager/policies/policy_handler.h

+  /**
+   * @brief Application queue ready for PTU
+   */
+  std::vector<uint32_t> queue_applications_for_ptu_;


@ydementieiev i think this container might need access synchronization

AKalinich-Luxoft · 2020-01-15T14:10:27Z

src/components/application_manager/include/application_manager/policies/policy_handler.h

@@ -598,13 +598,13 @@ class PolicyHandler : public PolicyHandlerInterface,
   * @param new_app_id app_id for this application
   * @param policy_id policy_id for this application
   */
-  void OnAddedNewApplicationToAppList(const uint32_t new_app_id,
-                                      const std::string policy_id) OVERRIDE;
+  void OnAddedNewApplicationToAppList(const uint32_t& new_app_id,


@ydementieiev there is no need to pass int as a reference

@AKalinich-Luxoft done f0f9ced

AKalinich-Luxoft · 2020-01-15T14:14:49Z

src/components/application_manager/src/policies/policy_handler.cc

-        queue_applications_for_ptu_.size());
-  }
+  sync_primitives::AutoLock lock(app_id_queue_lock_);
+  queue_applications_for_ptu_.insert(app_id);


@ydementieiev check for return result of insert operation. If the same app_id is inserted, count will not be changed

@AKalinich-Luxoft done f0f9ced

AKalinich-Luxoft · 2020-01-15T14:27:19Z

src/components/policy/policy_external/include/policy/update_status_manager.h

@@ -94,7 +94,7 @@ class UpdateStatusManager {
  /**
   * @brief Postponed update for PTU
   */
-  void OnUpdatePostponed();
+  void OnUpdateForNextInQueue();


@ydementieiev please update description

@AKalinich-Luxoft done f0f9ced

AKalinich-Luxoft · 2020-01-15T14:33:00Z

src/components/application_manager/include/application_manager/policies/policy_handler.h

-#ifndef EXTERNAL_PROPRIETARY_MODE
-  void OnPTUTimeOut() OVERRIDE;
-#endif
+  void OnPTUTimeOut();


@ydementieiev then add pure virtual OnPTUTimeOut into interface class for EXTERNAL_PROPRIETARY_MODE

AKalinich-Luxoft · 2020-01-15T17:09:33Z

src/components/application_manager/src/policies/policy_handler.cc

-  queue_applications_for_ptu_.insert(app_id);
-  policy_manager_->OnChangeApplicationCount(queue_applications_for_ptu_.size());
+  std::pair<std::set<uint32_t>::iterator, bool> result;
+  result = queue_applications_for_ptu_.insert(app_id);


@ydementieiev just

const auto result = queue_applications_for_ptu_.insert(app_id);

@AKalinich-Luxoft done 1f93a08

AKalinich-Luxoft · 2020-01-15T17:10:04Z

src/components/include/application_manager/policies/policy_handler_interface.h

@@ -660,6 +660,8 @@ class PolicyHandlerInterface : public VehicleDataItemProvider {
                                 const std::string& policy_app_id,
                                 const std::string& hmi_level) = 0;

+  virtual void OnPTUTimeOut() = 0;


@ydementieiev please add a description

@AKalinich-Luxoft done 1f93a08

AByzhynar · 2020-01-16T11:47:53Z

src/components/application_manager/include/application_manager/policies/policy_handler.h

@@ -183,9 +183,11 @@ class PolicyHandler : public PolicyHandlerInterface,
                         const std::string& policy_app_id,
                         const std::string& hmi_level) OVERRIDE;

-#ifndef EXTERNAL_PROPRIETARY_MODE
+  /**
+   * @brief OnPTUTimeOut the callback which signals if PTU timeout occured


@ydementieiev Suggested changes here:

the callback which signals if PTU timeout occured -> the callback which is performed when PTU timeout occurred

Move description to iface

@AByzhynar update description c04c115ce

AByzhynar · 2020-01-16T11:49:32Z

src/components/application_manager/include/application_manager/policies/policy_handler.h

@@ -422,6 +424,18 @@ class PolicyHandler : public PolicyHandlerInterface,
   */
  uint32_t GetAppIdForSending() const OVERRIDE;

+  /**
+   * @brief Add application to PTU queue if don't have application


@ydementieiev don't have application ... -> no application with the same app id exists

@AByzhynar update description c04c115ce

AByzhynar · 2020-01-16T11:50:24Z

src/components/application_manager/include/application_manager/policies/policy_handler.h

+  void PushAppIdToQueue(const uint32_t new_app_id);
+
+  /**
+   * @brief Remove first from queue application


@ydementieiev Remove the first application from applications queue

@AByzhynar update description c04c115ce

AByzhynar · 2020-01-16T11:51:05Z

src/components/application_manager/include/application_manager/policies/policy_handler.h

+   * @param new_app_id app_id for this application
+   * @param policy_id policy_id for this application
+   */
+  void OnAddedNewApplicationToAppList(const uint32_t new_app_id,


@ydementieiev Move description to iface

@AByzhynar leaved description only in iface c04c115ce

AByzhynar · 2020-01-16T11:51:53Z

src/components/application_manager/include/application_manager/policies/policy_handler.h

+                                      const std::string& policy_id) OVERRIDE;
+
+  /**
+   * @brief Application queue ready for PTU


@ydementieiev What does it mean queue ready for PTU?

@AByzhynar update description c04c115ce

AByzhynar · 2020-01-16T11:57:39Z

src/components/application_manager/src/application_manager_impl.cc

@@ -193,6 +193,7 @@ ApplicationManagerImpl::ApplicationManagerImpl(
              this, &ApplicationManagerImpl::OnTimerSendTTSGlobalProperties))
    , is_low_voltage_(false)
    , apps_size_(0)
+    , is_registered_in_timeout_(false)


@ydementieiev rename it according to the meaning please.
registered_during_timer_execution or ...after_timer_expired or ..before_expiration_timer_start_ , depends on the meaning

@AByzhynar done c04c115ce

…occurs during the retry sequence

AByzhynar · 2020-01-16T12:51:31Z

src/components/application_manager/src/policies/policy_handler.cc

+void PolicyHandler::OnAddedNewApplicationToAppList(
+    const uint32_t new_app_id, const std::string& policy_id) {
+  LOG4CXX_AUTO_TRACE(logger_);
+  if (last_registered_policy_app_id_ == policy_id) {


@ydementieiev swap comparables please

@AByzhynar swaped c04c115ce

AByzhynar · 2020-01-16T12:58:07Z

src/components/policy/policy_external/include/policy/update_status_manager.h

@@ -91,6 +91,12 @@ class UpdateStatusManager {
   */
  void OnUpdateTimeoutOccurs();

+  /**
+   * @brief Update status for next in queue application
+   * after previous has finished


@ydementieiev

previous status or previous update?

has finished -> has been finished or was finished

@AByzhynar update description c04c115ce

…rigger occurs during the retry sequence

AByzhynar · 2020-01-16T15:39:58Z

src/components/include/application_manager/policies/policy_handler_interface.h

@@ -410,6 +410,14 @@ class PolicyHandlerInterface : public VehicleDataItemProvider {
   */
  virtual void OnAppsSearchCompleted(const bool trigger_ptu) = 0;

+  /**
+   * @brief Notify that new applocation was added to application list


@ydementieiev still typo...?

@AByzhynar done d24d1e1e4f

AByzhynar · 2020-01-16T15:41:00Z

src/components/policy/policy_external/include/policy/policy_manager_impl.h

+  /**
+   * @brief Change applications count ready for PTU
+   * @param new_app_count new applications count for PTU
+   */


@ydementieiev Remove description form derived classes

@AByzhynar done d24d1e1e4f

AByzhynar · 2020-01-16T15:42:17Z

src/components/policy/policy_regular/include/policy/policy_manager_impl.h

+  /**
+   * @brief Change applications count ready for PTU
+   * @param new_app_count new applications count for PTU
+   */


@ydementieiev Same as above

@AByzhynar done d24d1e1e4f

…rigger occurs during the retry sequence

ydementieiev · 2020-01-16T18:24:42Z

@theresalech this PR passed internal Luxoft review and ready for Livio team review.

src/components/application_manager/include/application_manager/policies/policy_handler.h

src/components/policy/policy_regular/include/policy/update_status_manager.h

src/components/include/policy/policy_external/policy/policy_manager.h

src/components/include/policy/policy_regular/policy/policy_manager.h

src/components/policy/policy_regular/src/policy_manager_impl.cc

…rigger occurs during the retry sequence

src/components/application_manager/include/application_manager/policies/policy_handler.h

… some trigger occurs during the retry sequence

dboltovskyi · 2020-02-06T01:04:50Z

@ShobhitAd Please notice scripts in #2318 were updated.
However 2 of them are failed even if current PR would be merged to develop without conflicts. It seems GIT auto-merge works not so good.
Please see details in smartdevicelink/sdl_atf_test_scripts#2318 (comment)
Please do not merge this PR until issue is fixed.

…n in right place

dboltovskyi · 2020-02-11T00:53:30Z

@ShobhitAd Please notice all issues have been successfully fixed in ec86a40 and ready for review.

dboltovskyi · 2020-02-19T15:13:24Z

@theresalech Please notice all comments in current PR in core and corresponding one in scripts are addressed. Please advise when it's planned to finish PM review?

src/components/application_manager/src/policies/policy_handler.cc

src/components/policy/policy_external/include/policy/status.h

src/components/policy/policy_external/src/policy_manager_impl.cc

src/components/policy/policy_external/src/status.cc

src/components/policy/policy_external/src/update_status_manager.cc

src/components/policy/policy_regular/src/policy_manager_impl.cc

src/components/policy/policy_regular/src/status.cc

jacobkeeler · 2020-02-20T18:03:53Z

@ydementieiev After following the steps in #3136 (registering a second app during the retry sequence for the first app), I see an issue where the url parameter is missing from OnSystemRequest in the subsequent PTU retries after the first attempt fails. This means that the app cannot retrieve the policy table if the first attempt fails.

First request:

"notification": {
  "name": "OnSystemRequest",
  "correlationID": -1,
  "parameters": {
    "fileType": "JSON",
    "timeout": 500,
    "requestType": "PROPRIETARY",
    "offset": 1000,
    "length": 10000,
    "url": "http://192.168.1.166:3000/api/1/policies/proprietary"
  }
}

All subsequent requests:

"notification": {
  "name": "OnSystemRequest",
  "correlationID": -1,
  "parameters": {
    "fileType": "JSON",
    "timeout": 500,
    "requestType": "PROPRIETARY",
    "offset": 1000,
    "length": 10000
  }
}

Note that I am testing with EXTERNAL_PROPRIETARY

theresalech · 2020-02-25T15:17:23Z

@ydementieiev @dboltovskyi do you have an update here? We would like to be able to review and merge this PR by the end of this week, so testing on Core 6.1 can begin.

dboltovskyi · 2020-02-25T16:12:44Z

@theresalech Please notice we have identified one additional issue since last PM review. All updates are planned to be finished at 02/26 EOD EST

dboltovskyi · 2020-02-27T19:15:34Z

@jacobkeeler Please find an explanation for the comment: #3208 (comment):
We suppose you did manual testing to get this result.
As for EXTERNAL_PROPRIETARY HMI provides data in BC.OnSystemRequest including url
SDL just transfers this data to mobile app in OnSystemRequest.

We did some check using sdl_hmi and found out that within merge of RGNSD feature logic related to url was broken.
GetURLs RPC was replaced by GetPolicyConfigurationData but usage of a new data structure was not aligned.

We have created an issue against sdl_hmi: smartdevicelink/sdl_hmi#278

dboltovskyi · 2020-02-27T20:24:36Z

@theresalech Please notice we made all planned updates in sdl_core and sdl_atf_test_scripts so they are ready for PM review.
However within merge of WebEngine feature there are a few conflicts which needs to be resolved (in core and scripts).
We have a plan to finish this activity tomorrow.

src/components/policy/policy_regular/src/update_status_manager.cc

dboltovskyi · 2020-02-28T15:48:01Z

@jacobkeeler Please notice we resolved conflicts in core and scripts, so both PRs are ready for review.

ydementieiev requested review from AKalinich-Luxoft, AByzhynar, LitvinenkoIra, mked-luxoft and mkorniichuk January 13, 2020 07:38

AKalinich-Luxoft suggested changes Jan 13, 2020

View reviewed changes

mked-luxoft suggested changes Jan 14, 2020

View reviewed changes

AKalinich-Luxoft suggested changes Jan 15, 2020

View reviewed changes

AKalinich-Luxoft approved these changes Jan 15, 2020

View reviewed changes

AKalinich-Luxoft requested a review from LuxoftAKutsan January 15, 2020 19:28

mked-luxoft approved these changes Jan 16, 2020

View reviewed changes

AByzhynar suggested changes Jan 16, 2020

View reviewed changes

Start the new PTU after a failed retry sequence in case some trigger …

c5a845f

…occurs during the retry sequence

AByzhynar reviewed Jan 16, 2020

View reviewed changes

AByzhynar suggested changes Jan 16, 2020

View reviewed changes

fixup! Start the new PTU after a failed retry sequence in case some t…

c04c115

…rigger occurs during the retry sequence

AByzhynar reviewed Jan 16, 2020

View reviewed changes

AByzhynar approved these changes Jan 16, 2020

View reviewed changes

fixup! Start the new PTU after a failed retry sequence in case some t…

d24d1e1

…rigger occurs during the retry sequence

ydementieiev removed request for LuxoftAKutsan, LitvinenkoIra and mkorniichuk January 16, 2020 18:23

ShobhitAd requested changes Jan 31, 2020

View reviewed changes

Yevhenii Dementieiev (GitHub) added 2 commits January 31, 2020 12:57

fixup! Start the new PTU after a failed retry sequence in case some t…

c4f21ec

…rigger occurs during the retry sequence

Check coding style

5a112e5

ShobhitAd requested changes Feb 4, 2020

View reviewed changes

src/components/application_manager/include/application_manager/policies/policy_handler.h Outdated Show resolved Hide resolved

fixup! fixup! Start the new PTU after a failed retry sequence in case…

96f6b47

… some trigger occurs during the retry sequence

ShobhitAd approved these changes Feb 5, 2020

View reviewed changes

dboltovskyi mentioned this pull request Feb 6, 2020

Scripts for defect 3136 smartdevicelink/sdl_atf_test_scripts#2318

Merged

1 task

Yevhenii Dementieiev (GitHub) and others added 2 commits February 10, 2020 22:54

Merge remote-tracking branch 'origin/develop' into fix/ptu_failed_retry

6a2c298

Remove redundant UPDATE_NEEDED notifications and add this notificatio…

ec86a40

…n in right place

dboltovskyi mentioned this pull request Feb 12, 2020

Redundant SDL.OnStatusUpdate(UPDATE_NEEDED) notification is sent once device is consented #3237

Closed

jacobkeeler requested changes Feb 19, 2020

View reviewed changes

jacobkeeler linked an issue Feb 19, 2020 that may be closed by this pull request

Redundant SDL.OnStatusUpdate(UPDATE_NEEDED) notification is sent once device is consented #3237

Closed

sniukalov and others added 3 commits February 27, 2020 16:18

Remove redundant

ca790d7

Changed the condition for ptu requested

b1acdb5

Merge commit '2ed16e5905' into fix/ptu_failed_retry

e4eac44

jacobkeeler requested changes Feb 27, 2020

View reviewed changes

src/components/policy/policy_regular/src/update_status_manager.cc Show resolved Hide resolved

Merge remote-tracking branch 'smart/develop' into fix/ptu_failed_retry

2d7fe39

jacobkeeler approved these changes Feb 28, 2020

View reviewed changes

jacobkeeler merged commit ce12181 into smartdevicelink:develop Feb 28, 2020

theresalech mentioned this pull request Mar 2, 2020

SDL does not start the new PTU after a failed retry sequence in case some trigger occurs during the retry sequence #3136

Closed

		@@ -1586,6 +1586,8 @@ class ApplicationManagerImpl

		uint32_t apps_size_;

		bool is_registered_in_timeout_;

	* @brief Check that application for PTU more than zero
	* @brief Check that new applications for PTU were registered

		@@ -550,6 +555,10 @@ void PolicyManagerImpl::OnPTUFinished(const PtProcessingResult ptu_result) {

		update_status_manager_.OnValidUpdateReceived();

		if (HasApplicationForPTU()) {

Start the new PTU after a failed retry sequence #3208

Start the new PTU after a failed retry sequence #3208

Conversation

ydementieiev commented Jan 13, 2020 • edited Loading

Risk

Summary

CLA

AKalinich-Luxoft commented Jan 13, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ydementieiev commented Jan 13, 2020 •

edited

Loading