Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDL 0173] - Read Generic Network Signal Data Implementation #210

Merged
merged 8 commits into from
Aug 30, 2019
Merged

[SDL 0173] - Read Generic Network Signal Data Implementation #210

merged 8 commits into from
Aug 30, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jul 29, 2019 •
edited by LuxoftAKutsan
Loading

Implements #0200
SDL core issue : smartdevicelink/sdl_core#2840
SDL evolution issue : smartdevicelink/sdl_evolution#768
This PR is ready for review.

Testing Plan

Manual testing done accotring to attached manual test plan
RGNSD.zip

Summary

Was added GetPolicyConfigurationData view for configuring and sending request.

GetURLs request was removed from web hmi and changed to GetPolicyConfigurationData request for policy update sequence.

CLA

@LuxoftAKutsan LuxoftAKutsan changed the title Implementation of feature read generic network signal data [SDL 0173] - Read Generic Network Signal Data Implementation Jul 29, 2019
@LuxoftAKutsan
Copy link
Contributor

LuxoftAKutsan commented Jul 29, 2019 •
edited by AStasiuk
Loading

@atiwari9 please approve this PR

@atiwari9
Copy link

Approved from Ford side. Ready for Livio review

@LuxoftAKutsan LuxoftAKutsan mentioned this pull request Jul 29, 2019
Merged
1 task
jacobkeeler
jacobkeeler requested changes Aug 15, 2019
View reviewed changes
ffw/BasicCommunicationRPC.js Outdated Show resolved Hide resolved
ffw/BasicCommunicationRPC.js Outdated Show resolved Hide resolved
ffw/BasicCommunicationRPC.js Show resolved Hide resolved
@AKalinich-Luxoft AKalinich-Luxoft force-pushed the feature/read_generic_network_signal_data branch from ad93db4 to cf36a64 Compare August 19, 2019 19:16
@jacobkeeler
Copy link
Contributor

Not certain if this is just because the revisions haven't been implemented yet, but currently the HMI does not include dataType when sending a SubscribeVehicleData response for custom data, resulting in Core marking the message invalid.

@alexkutsan
Copy link

alexkutsan commented Aug 23, 2019 •
edited by GetmanetsIrina
Loading

@jacobkeeler would you like to review revisions in a separate PR or I will merge it to feature branch?
#212

The same actual for sdl_core smartdevicelink/sdl_core#2981 , smartdevicelink/sdl_atf_test_scripts#2223

@GetmanetsIrina
Copy link

GetmanetsIrina commented Aug 23, 2019 •
edited
Loading

@jacobkeeler, thanks for comment, we will fix this HMI issue.
And also please use the attached instruction RGNSD.zip, for successful processing of the custom vehicle data HMI should have custom data in VehicleInfo tab.

@AKalinich-Luxoft
Copy link
Contributor

AKalinich-Luxoft commented Aug 23, 2019 •
edited
Loading

Not certain if this is just because the revisions haven't been implemented yet, but currently the HMI does not include dataType when sending a SubscribeVehicleData response for custom data, resulting in Core marking the message invalid.

@jacobkeeler Thanks for finding this issue. Logic of SubscribeVD/UnsubscribeVD has been updated to consider availability of custom vehicle params which may be not defined and unknown for HMI.
Fixed in 36e5be2

@AKalinich-Luxoft AKalinich-Luxoft force-pushed the feature/read_generic_network_signal_data branch from 36e5be2 to 67f24dd Compare August 23, 2019 19:03
@AKalinich-Luxoft AKalinich-Luxoft force-pushed the feature/read_generic_network_signal_data branch from 67f24dd to 1348934 Compare August 26, 2019 16:08
valerii and others added 6 commits August 26, 2019 16:53
@AKalinich-Luxoft
Implementation of feature read generic network signal data
ba0f125 
Was added GetPolicyConfigurationData view
for configuring and sending request.

GetURLs request was removed from web hmi and
changed to GetPolicyConfigurationData request
for policy update sequence.
@AKalinich-Luxoft
Updated name of some variables
d507c0a 
Updated name in ffw/BasicCommunicationRPC.js:
 - requstedData -> requestedData
 - dataToremove -> dataToRemove
@AKalinich-Luxoft
Update vehicle data mapping version after PTU
cad8aac 
There were done some minor changes to make parameters
version update only after PTU file has been recevied
@AKalinich-Luxoft
Fixes after merge conflicts
9302ac7
@AKalinich-Luxoft
Change custom vehicle data type
fcf3228 
Change custom vehcile data type from
OEM_SPECIFIC to VEHICLEDATA_OEM_CUSTOM_DATA.
@AKalinich-Luxoft
Fix VD susbscription for unavailable custom params
0ae8a93 
Also was fixed sending of the empty OnVD notification
Fixed removal of custom VD parameters if it was removed in
editor.
Fixed calculation of result code for SubscribeVD and UnsubscribeVD.
@AKalinich-Luxoft AKalinich-Luxoft force-pushed the feature/read_generic_network_signal_data branch from 1348934 to 0ae8a93 Compare August 26, 2019 20:54
@AKalinich-Luxoft
Copy link
Contributor

HMI has been rebased on the latest develop in 0ae8a93

fixup! Result code for SubscribeVehicleData request
cb240f4 
The problem was when the application try to subscribe to vehicledata second
time, result code should be IGNORED instead of DATA_NOT_AVAILABLE
@jacobkeeler jacobkeeler merged commit effaff8 into develop Aug 30, 2019
@jacobkeeler jacobkeeler deleted the feature/read_generic_network_signal_data branch August 30, 2019 18:11
@jacobkeeler jacobkeeler mentioned this pull request Aug 30, 2019
Closed
jacobkeeler added a commit that referenced this pull request Sep 17, 2019
@jacobkeeler
Re-add removed function
a44e39c 
The `OnSystemRequestHandler` function was introduced in #210, but removed when #216 was improperly rebased. This reintroduces that change
@jacobkeeler jacobkeeler mentioned this pull request Sep 17, 2019
Merged
1 task
@dboltovskyi dboltovskyi mentioned this pull request Feb 27, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LuxoftAKutsan @atiwari9 @jacobkeeler @alexkutsan @GetmanetsIrina @AKalinich-Luxoft