Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VEHICLEDATA_OEM_CUSTOM_DATA enum value processing #212

Conversation

ghost
Copy link

@ghost ghost commented Jul 30, 2019

This PR is ready for review.

Summary

Change custom vehcile data type from OEM_SPECIFIC to OEM_VEHICLE_DATA_TYPE.

CLA

@ghost
Copy link
Author

ghost commented Jul 30, 2019

@atiwari9 Please review

@atiwari9
Copy link

Approved as this is needed to accommodate following changes as mentioned in SDL-0173 propsoal.

@ghost ghost force-pushed the fix/change_custom_data_type branch from 528a73f to 0e12f4c Compare July 31, 2019 13:03
@LuxoftAKutsan LuxoftAKutsan changed the title Change custom vehicle data type Add VEHICLEDATA_OEM_CUSTOM_DATA enum value processing Aug 2, 2019
@AKalinich-Luxoft AKalinich-Luxoft force-pushed the feature/read_generic_network_signal_data branch from ad93db4 to cf36a64 Compare August 19, 2019 19:16
Change custom vehcile data type from
OEM_SPECIFIC to VEHICLEDATA_OEM_CUSTOM_DATA.
@LuxoftAKutsan
Copy link
Contributor

@jacobkeeler this PR is related to smartdevicelink/sdl_evolution#806
Should I merge it to feature branch or you will review it separately?

@LuxoftAKutsan LuxoftAKutsan merged commit 8abe40f into feature/read_generic_network_signal_data Aug 23, 2019
@LuxoftAKutsan LuxoftAKutsan deleted the fix/change_custom_data_type branch August 23, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants