Use Mobile_API files from RPC Spec submodule #3270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the files pulled from the rpc spec submodule instead
This reverts commit a089e01.
ShobhitAd
reviewed
Mar 4, 2020
Co-Authored-By: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>
ShobhitAd
approved these changes
Mar 4, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Build SDL Core and ensure none of the build steps have changed.
Summary
The implementation of [SDL 0234] Proxy Library RPC Generation created an RPC Spec submodule where the Mobile_API.xml and Mobile_API.xsd files would be pulled from the RPC Spec repository. To avoid maintaining two seperate .xml and .xsd files between the core repository and the rpc spec, I have removed the files from the Core repository.
The cmake process will check if the user has initialized the rpc spec submodule and will throw an error if the directory does not exist.
If the submodule directory exists, cmake will copy the .xml and .xsd files from the rpc_spec submodule directory to Cores directory src/components/interfaces/.