Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL-0274: add preferred FPS to VideoStreamingCapability #3437

Merged
merged 9 commits into from
Feb 4, 2021

Conversation

shiniwat
Copy link
Contributor

Fixes #3243

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

N/A

Summary

This PR is for SDL-0274: add preferred FPS to VideoStreamingCapability.

Changelog

Breaking Changes
  • N/A
Enhancements
  • N/A
Bug Fixes

Tasks Remaining:

  • none

CLA

@jordynmackool
Copy link

Hi @shiniwat, this PR should point to the branch of the RPC Spec that contains the changes needed for this feature.

RPC Spec changes are not merged until the feature has been properly tested with all the required projects and it is confirmed the feature will make it into the slated releases.

Once this PR is updated and tested against the RPC Spec feature branch, please tag me requesting a review.

@jordynmackool
Copy link

@shiniwat is this ready for Livio review?

@shiniwat
Copy link
Contributor Author

shiniwat commented Jan 5, 2021

Hi @jordynmackool,
While Travis CI seems to fail with "The job exceeded the maximum time limit for jobs, and has been terminated." error, the build works fine on my devbox (Ubuntu 1804). I believe this is ready for Livio review.

.gitmodules Outdated Show resolved Hide resolved
Copy link
Contributor

@jacobkeeler jacobkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

Also updated/restored .gitmodules as suggested.
@jacobkeeler
Copy link
Contributor

@shiniwat Please update the rpc_spec submodule to the latest develop to fix merge conflicts

@jacobkeeler jacobkeeler merged commit a0bd7e3 into smartdevicelink:develop Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants