-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDL-0274: add preferred FPS to VideoStreamingCapability #3437
SDL-0274: add preferred FPS to VideoStreamingCapability #3437
Conversation
Hi @shiniwat, this PR should point to the branch of the RPC Spec that contains the changes needed for this feature. RPC Spec changes are not merged until the feature has been properly tested with all the required projects and it is confirmed the feature will make it into the slated releases. Once this PR is updated and tested against the RPC Spec feature branch, please tag me requesting a review. |
@shiniwat is this ready for Livio review? |
Hi @jordynmackool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
Also updated/restored .gitmodules as suggested.
@shiniwat Please update the rpc_spec submodule to the latest |
Fixes #3243
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
N/A
Summary
This PR is for SDL-0274: add preferred FPS to VideoStreamingCapability.
Changelog
Breaking Changes
Enhancements
Bug Fixes
Please note that rpc_spec submodule must be updated. I will update the submodule as soon as another PR at [SDL 0274] add preferred FPS to VideoStreamingCapability rpc_spec#229 has been merged.
Tasks Remaining:
CLA