Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDL-0323] Align video streaming parameters with VideoStreamingCapability #1878

Merged
merged 3 commits into from
Feb 4, 2021

Conversation

shiniwat
Copy link
Contributor

Fixes #1860

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

This PR has no new Unit Tests

Core Tests

sdl_core PR : smartdevicelink/sdl_core#3437

Core version / branch / commit hash / module tested against: smartdevicelink/sdl_core#3437
HMI name / version / branch / commit hash / module tested against: smartdevicelink/sdl_hmi#436

Summary

This PR has dependency on SDL -274: add preferredFPS to VideoStreamingCapability. Hence this PR is on top of PR at #1613.

Changelog

Breaking Changes
  • n/a
Enhancements
  • n/a
Bug Fixes

Tasks Remaining:

  • n/a

CLA

…eoStreamingParameters with VideoStreamingCapability.
@jordynmackool
Copy link
Contributor

@shiniwat please let me know when this PR is ready for Livio Review

@shiniwat
Copy link
Contributor Author

Hi @jordynmackool,
Because this PR is on top of #1613 PR, PR for SDL-0274 should be reviewed first, and then this one is ready for review.

@NicoleYarroch
Copy link
Contributor

@shiniwat I approved and merged PR #1613 into develop. Can you please merge develop into your branch for this PR and fix the merge conflicts?

The develop branch has a fix for tests not building on Xcode 12.3 and 12.4 so we no longer have to use a workaround. Just make sure to run bash carthage-build.sh update --no-use-binaries --platform ios in the root folder of the library before building the tests.

Please tag me when you are ready for a review. Thanks!

@NicoleYarroch NicoleYarroch self-requested a review February 3, 2021 14:33
@NicoleYarroch NicoleYarroch added manager-streaming-video Relating to the manager layer - video streaming proposal Accepted SDL Evolution Proposal labels Feb 3, 2021
@joeljfischer joeljfischer changed the title [SDL-0323] Align vide streaming parameters with VideoStreamingCapability [SDL-0323] Align video streaming parameters with VideoStreamingCapability Feb 3, 2021
@shiniwat
Copy link
Contributor Author

shiniwat commented Feb 4, 2021

Hi @NicoleYarroch, I have merged develop into this PR, made sure running bash carthage-build.sh update --no-use-binaries --platform ios, and resolved conflicts at SDLVideoStreamingLifecycleManager.m.
I hope this PR is ready for re-review. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
manager-streaming-video Relating to the manager layer - video streaming proposal Accepted SDL Evolution Proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDL 0323 - Align video streaming parameters with VideoStreamingCapability
3 participants