Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accepted Revision SDL-0293 Enable OEM exclusive apps support #1106

Merged
merged 4 commits into from
Jan 28, 2021
Merged

Accepted Revision SDL-0293 Enable OEM exclusive apps support #1106

merged 4 commits into from
Jan 28, 2021

Conversation

LitvinenkoIra
Copy link
Contributor

@LitvinenkoIra LitvinenkoIra commented Dec 14, 2020 •
edited
Loading

Updates to reflect the Steering Committee agreed-upon revisions in this comment

@LitvinenkoIra
Copy link
Contributor Author

@mrapitis please review

@jordynmackool
Copy link
Contributor

@LitvinenkoIra prior to tagging Livio to review, please add yourself as an author to the proposal.

@mrapitis
Copy link
Contributor

@LitvinenkoIra changes approved from the Ford side.

@LitvinenkoIra
Copy link
Contributor Author

@pelsila This PR is ready for review. Thank you!

@vladmu
Copy link
Contributor

vladmu commented Dec 16, 2020 •
edited
Loading

@pelsila @mrapitis @LitvinenkoIra @AKalinich-Luxoft I have point regarding proposed changes because I see some data inconsistency in the way proposed here. systemHardwareVersion looks very similar to systemSoftwareVersionwhich was not placed in VehicleType but is a separate parameter in RegisterAppInterfaceResponse and GetSystemInfo function. So my concern is that in the proposed revision systemHardwareVersion is a part of VehicleType and not implemented in the same way as systemSoftwareVersion otherwise we need the last one to be implemented in the same way as systemHardwareVersion proposed here and put it into VehicleType also to match send it to the mobile criteria, then this revision should be extended.

@jordynmackool jordynmackool mentioned this pull request Dec 16, 2020
Closed
@jordynmackool
Copy link
Contributor

jordynmackool commented Dec 16, 2020 •
edited
Loading

@vladmu please post your feedback on the newly created review issue here: #1108

@smartdevicelink smartdevicelink locked and limited conversation to collaborators Dec 16, 2020
@LitvinenkoIra LitvinenkoIra force-pushed the revise/0293-vehicle-type-filter branch from 31a0f53 to b09a57c Compare December 21, 2020 16:37
@jordynmackool jordynmackool mentioned this pull request Jan 4, 2021
Closed
@smartdevicelink smartdevicelink unlocked this conversation Jan 28, 2021
@jordynmackool
Copy link
Contributor

@LitvinenkoIra please let me know when this PR has been updated to reflect the Steering Committee agreed-upon revisions in this comment . Thanks!

@mrapitis mrapitis mentioned this pull request Jan 28, 2021
Merged
@LitvinenkoIra
Copy link
Contributor Author

@jordynmackool PR is ready for review. Please check 22d9777 and 0ccbbca
Thank you!

@LitvinenkoIra LitvinenkoIra changed the title Revise SDL-0293 Enable OEM exclusive apps support Accepted Revision SDL-0293 Enable OEM exclusive apps support Jan 28, 2021
@jordynmackool jordynmackool merged commit e272967 into smartdevicelink:master Jan 28, 2021
This was referenced Jan 28, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordynmackool jordynmackool jordynmackool approved these changes

@pelsila pelsila pelsila approved these changes

Assignees
No one assigned
Labels
core hmi in review ios java suite javascript protocol rpc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LitvinenkoIra @jordynmackool @mrapitis @vladmu @pelsila