Last mile navigation feature #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jack-Byrne
pushed a commit
that referenced
this pull request
Jan 23, 2018
…haviour Fix FM/AM radio band switching
Added processing new params for SendLocation
Added set of new png images for navigation module.
Related RPC for work with waypoints information according to proposal: GetWayPoints, SubscribeWayPoints, UnsubscribeWayPoints, OnWayPointsChanged.
1. Click anywhere on the map: (current behavior, no change)
1.1 If there is no active mark on the map, place a pin/marker on the
map to show the current selected location.
1.2 If there is an active mark on the map, move the current marker
to the new location. (Remove the current pin and place one on new
location)
2. Button “Waypoints”: (changes)
2.1 If the waypoint list is not empty, it shall toggle the state of
showing a list of waypoints and hide the list.
2.2 If the list is empty, shall show an error message or show an
empty list or get disabled.
3. Button “Add WayPoint”: (changes)
3.1 If there is a selected location (active mark), add the location
to the waypoints list and show the waypoint list so that the user
knows it (also send onWayPointChange Notification if needed).
3.2 If there is no active mark on the map, show a message ask user
to place a mark on the map first before click the button.
4. Button “Clear”: clear all marks on the map. (new button)
5. Button “Start Animation”/”Stop Animation”: start/stop animation.
(current behavior, no change)
6. Button “Navigate”:
6.1 If there is a selected location, set it as the destination (new
last waypoint). Calculate and show the route.
6.2 If there is no selected location, (changes) and
6.2.1 If the waypoint is not empty, set the last waypoint as
destination, calculate and show the route.
6.2.2 If the waypoint is empty, show a message ask user to set a
destination.
7. “Places” button. – not used.
8. Need to change the inscription "Please select a WayPoint" to "Please
select a place on the map".
Fixed SendLocation hanlders to work with waypoints. Small updates in waypoints logic.
AKalinich-Luxoft
force-pushed
the
feature/last_mile_navigation
branch
from
77e313f
to
b8c7648
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HMI implementation of Last Mile Navigation feature
Proposal: Last Mile Navigation